Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendAction should return error if it's rejected from local action pool #1533

Closed
zjshen14 opened this issue Oct 4, 2019 · 0 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@zjshen14
Copy link
Contributor

zjshen14 commented Oct 4, 2019

What would you like to be added:

In SendAction, we should change the order of processing a send action:

  1. Insert it into local action pool
  2. If everything goes well, we move forward to broadcast it to other nodes

If error happens at 1, we should notify users of the error.

Another thing we want to measure is how much we add the e2e latency, because we now need to wait synchronously until the actpool adds or rejects the action.

Why is this needed:

Users sometimes are confused that they send an action, but it eventually isn't put on chain. They have no information to tell what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants