-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Vue 3 #10298
Upgrade to Vue 3 #10298
Conversation
for more information, see https://pre-commit.ci
<template> | ||
<div class="page"> | ||
<h1>Hello Vuorld!</h1> | ||
<script setup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to roll this back to the options API version ; we're still recommending the options API for Open Library for consistency with existing components and for being easier to use on simple cases -- which is most of Open Library's components.
Wooohooo!!!! Great work @RayBB !!! This has stumped the team for multiple attempts 😁 This works perfect across all our components, and all the tech decision you've made here make perfect sense! Thank you!! |
Closes #7547
Overview
This PR upgrades Vue. Due to Vue's architecture, this requires upgrading all Vue-related dependencies simultaneously.
Changes Needed
destroyed
->unmounted
andbeforeDestroy
->beforeUnmount
plugin:vue/vue3-recommended
(which will make many automatic changes for best practices) use vue recommended sytles #10339Technical Details
Implementation Notes
Testing Instructions
docker compose up docker compose run --rm home make components # visit http://localhost:8080/explore?ol_base=openlibrary.org
To test the dev setup run (outside of docker)
npm install --no-audit COMPONENT="LibraryExplorer" npm run serve
TBH, I'm not really sure if this is needed but we already had it so I updated it.
Test the following components:
Stakeholders
@cdrini
confidence and access to the correct context to evaluate and use this code. -->