-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade vue-muliselect to beta for Vue 3 support #8384
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ee2b7c2
to
a6ac071
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8384 +/- ##
=======================================
Coverage 17.44% 17.44%
=======================================
Files 89 89
Lines 4792 4792
Branches 848 848
=======================================
Hits 836 836
Misses 3436 3436
Partials 520 520 ☔ View full report in Codecov by Sentry. |
Updated to the new non-beta version and it works well. |
This will never work because we need everything upgraded at once. Closing in favor of #10298 |
Contributes to #7547
Upgrades vue-multiselect to beta version for Vue 3 support.
According to the docs here the main change is that:
But we don't use
input
in the muliselect right now so we should have no problems.Technical
Using isn't ideal but it's better than migrating to another component right now.
Testing
Use language selector in library explorer.
Screenshot
Stakeholders