Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vue-muliselect to beta for Vue 3 support #8384

Closed

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Oct 6, 2023

Contributes to #7547

Upgrades vue-multiselect to beta version for Vue 3 support.

According to the docs here the main change is that:

input is now update:modelValue. This is so v-model works in Vue 3.

But we don't use input in the muliselect right now so we should have no problems.

Technical

Using isn't ideal but it's better than migrating to another component right now.

Testing

Use language selector in library explorer.

Screenshot

Stakeholders

@RayBB RayBB mentioned this pull request Oct 6, 2023
14 tasks
@RayBB

This comment was marked as outdated.

@jimchamp

This comment was marked as outdated.

@RayBB RayBB force-pushed the fix/upgrade-vue-multiselect branch from ee2b7c2 to a6ac071 Compare December 23, 2024 06:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.44%. Comparing base (3025f5d) to head (a6ac071).
Report is 38 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8384   +/-   ##
=======================================
  Coverage   17.44%   17.44%           
=======================================
  Files          89       89           
  Lines        4792     4792           
  Branches      848      848           
=======================================
  Hits          836      836           
  Misses       3436     3436           
  Partials      520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RayBB RayBB marked this pull request as ready for review December 23, 2024 06:28
@RayBB
Copy link
Collaborator Author

RayBB commented Dec 23, 2024

Updated to the new non-beta version and it works well.
@jimchamp can you review when you get a chance? :)

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 23, 2024
@RayBB RayBB requested a review from jimchamp December 23, 2024 06:30
@RayBB RayBB added the Priority: 2 Important, as time permits. [managed] label Dec 23, 2024
@RayBB RayBB assigned cdrini and unassigned jimchamp Dec 31, 2024
@RayBB RayBB requested review from cdrini and removed request for jimchamp December 31, 2024 18:25
@RayBB
Copy link
Collaborator Author

RayBB commented Dec 31, 2024

@cdrini assigning you as @jimchamp mentioned that you'll need to take the final look at this one

@cdrini
Copy link
Collaborator

cdrini commented Jan 8, 2025

No luck I'm afraid 😁 From testing:
image

@cdrini cdrini added Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] and removed Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. labels Jan 8, 2025
@RayBB
Copy link
Collaborator Author

RayBB commented Jan 8, 2025

This will never work because we need everything upgraded at once. Closing in favor of #10298

@RayBB RayBB closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants