Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vue import extensions to use .vue #10303

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Jan 9, 2025

Implements part of #7547

This PR adds explicit .vue file extensions to component imports to ensure compatibility with Vite's module resolution requirements (see Vite issue #178). While webpack is more lenient with extension resolution, Vite strictly requires these extensions.

This change is a prerequisite for the Vue 3 migration (#10298) and has been implemented incrementally to maintain code clarity. Similar changes have been previously made in other parts of the codebase (see PR #10303).

Type: refactor

Technical

  • Adds explicit .vue extensions to all component imports
  • No functional changes to component behavior
  • Maintains consistent import syntax across the codebase

Testing

  1. Run make components to verify successful component compilation
  2. Verify that all components render and function as expected

The changes are isolated to import statements and pose minimal risk to application functionality.

Screenshot

N/A - No UI changes

Stakeholders

@RayBB RayBB added Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Affects: Developers Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. labels Jan 9, 2025
@cdrini cdrini self-assigned this Jan 10, 2025
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Tested library explorer on testing and worked as normal 👍

@cdrini cdrini merged commit 20c93a2 into master Jan 10, 2025
7 checks passed
@cdrini cdrini deleted the update-vue-import-extensions branch January 10, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Developers Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants