Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2308: Add extra few days in SuccessRateLine if survey is still running #2338

Merged
merged 1 commit into from
May 7, 2024

Conversation

anaPerezGhiglia
Copy link
Contributor

@anaPerezGhiglia anaPerezGhiglia commented May 7, 2024

This is a follow up of #2336 suggestion comment

Also, @matiasgarciaisaia slack comment about the x-axis max value 👇

We're showing at least one month, but if the survey has been running for, say, 42 days - we show 42 days, then.
My suggestion was to add some extra days (say, 45, 47?) to give the idea of incompleteness.

Evidence

survey.state = running & started less than a month ago
image

survey.state = running & started more than one month ago
image

survey.state = terminated & started more than one month ago
image

for #2308

Copy link
Member

@matiasgarciaisaia matiasgarciaisaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@anaPerezGhiglia anaPerezGhiglia merged commit c046534 into main May 7, 2024
2 checks passed
@anaPerezGhiglia anaPerezGhiglia deleted the enhancement/2308-add-few-more-days branch May 7, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants