#2308: Fix SuccessRateLine chart #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify SuccessRateLine chart by recibin a single data object instead of a list of them. This seems to be a leftofver from copying Forecasts component * Simplify SurveyShow by avoid putting together quota bucket forecasts and success rate values
This was referenced May 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
100%ceil. This didn't (and doesn't) make any sense. It was this "forecasted" date the one that was messing around the x-axis, since we were selecting this date as the end-date of the chart.SuccessRateLinecomponent by reciving a single data object instead of a list of them. This seems to be a leftover from copying Forecasts componentSurveyShowcomponent by avoid putting together quota bucket forecasts and success rate valuesEvidence
Before
After
closes #2308