Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success Rate chart has issues with the x-axis scale #2308

Closed
manumoreira opened this issue Nov 3, 2023 · 3 comments · Fixed by #2336
Closed

Success Rate chart has issues with the x-axis scale #2308

manumoreira opened this issue Nov 3, 2023 · 3 comments · Fixed by #2336
Assignees
@anaPerezGhiglia

Comments

@manumoreira
Copy link
Contributor

After a two week of running a survey the x-axis of the success rate chart changed its scale, making it really difficutl to read.

image

This might be related to the quotas line-chart and its completion estimation

You can check an example here
@matiasgarciaisaia
Copy link
Member

We should either cap the number of days into the future that the chart shows, and/or use a chart that's zoomable/interactive.

@manumoreira
Copy link
Contributor Author

Sure, but I don't understand why the chart is changing the scale to 7 years, when it just needs to show data for 2 weeks

@matiasgarciaisaia
Copy link
Member

Oh, I overlooked that.

Back when the success rate was plotted with the completes, the x-axis would grow by a huge deal when the survey got estimated to last for a really long time due to a really low success rate. I'm not sure if that was somehow carried over here, or if it's a completely separate bug/issue. We should investigate that 👍

@anaPerezGhiglia anaPerezGhiglia self-assigned this Apr 26, 2024
@anaPerezGhiglia anaPerezGhiglia mentioned this issue Apr 29, 2024
Merged
anaPerezGhiglia added a commit that referenced this issue May 6, 2024
@anaPerezGhiglia
#2308: Fix SuccessRateLine chart (#2336)
2addf8f 
* Fix SuccessRateLine chart
   * Simplify SuccessRateLine chart by receiving a single data object instead
   of a list of them. This seems to be a leftofver from copying Forecasts
   component
   * Simplify SurveyShow by avoid putting together quota bucket forecasts and
   success rate values

* Update success rate chart title
@anaPerezGhiglia anaPerezGhiglia mentioned this issue May 7, 2024
Merged
anaPerezGhiglia added a commit that referenced this issue May 7, 2024
@anaPerezGhiglia
#2308: Add extra few days in SuccessRateLine if survey is still runni…
c046534 
…ng (#2338)
@anaPerezGhiglia anaPerezGhiglia mentioned this issue Jun 7, 2024
Merged
@manumoreira manumoreira moved this to Verified in Dev sprints 24-25 Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anaPerezGhiglia anaPerezGhiglia

Labels
None yet
Projects
Dev sprints 24-25
Status: Verified
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2308: Fix SuccessRateLine chart instedd/surveda
3 participants
@matiasgarciaisaia @anaPerezGhiglia @manumoreira