Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug forcing tm_g_lineplot to initialize with a table #899

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Fix bug forcing tm_g_lineplot to initialize with a table #899

merged 5 commits into from
Dec 1, 2023

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #823

@edelarua edelarua added the sme label Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0 ❌
280 runs  168 ✔️ 112 💤 0 ❌

Results for commit 30affea.

♻️ This comment has been updated with latest results.

@shajoezhu

This comment was marked as off-topic.

Sign in to view
@shajoezhu shajoezhu self-assigned this Dec 1, 2023
@shajoezhu shajoezhu mentioned this pull request Dec 1, 2023
Closed
shajoezhu
shajoezhu approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua . It looks well.

image

I have a comment with table and plot alignment. But I think this should be addressed seperately.

@edelarua edelarua merged commit 38d7395 into main Dec 1, 2023
24 checks passed
@edelarua edelarua deleted the 823_forced_lineplot_table@main branch December 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add option to *not* display table in tm_g_lineplot()
2 participants
@edelarua @shajoezhu