Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add option to *not* display table in tm_g_lineplot() #823

Closed
3 tasks done
thomas-neitmann opened this issue Aug 17, 2023 · 3 comments · Fixed by #899
Closed
3 tasks done

[Feature Request]: Add option to *not* display table in tm_g_lineplot() #823

thomas-neitmann opened this issue Aug 17, 2023 · 3 comments · Fixed by #899
Assignees
Labels
bug Something isn't working enhancement New feature or request sme

Comments

@thomas-neitmann
Copy link

Feature description

I'd like an option to suppress the table beneath the plot in tm_g_lineplot().

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@thomas-neitmann thomas-neitmann added the enhancement New feature or request label Aug 17, 2023
@lcd2yyz
Copy link

lcd2yyz commented Aug 18, 2023

This looks to be a bug actually, there is a discrepancy between the default param specified in template_g_lineplot which has table = c("n", "mean_sd", "median", "range"), which overwrites whatever has been specified in table argument in tm_g_lineplot. Thanks for reporting!

@lcd2yyz lcd2yyz added bug Something isn't working sme labels Aug 18, 2023
@Stav-Kr
Copy link

Stav-Kr commented Sep 28, 2023

I recently encountered this issue too, I set table = NULL but the table appears regardless. Only workaround I found was to use tern::g_lineplot() on its own.

@crystalluckett-sanofi
Copy link

crystalluckett-sanofi commented Nov 28, 2023

This looks to be a bug actually, there is a discrepancy between the default param specified in template_g_lineplot which has table = c("n", "mean_sd", "median", "range"), which overwrites whatever has been specified in table argument in tm_g_lineplot. Thanks for reporting!

@lcd2yyz We may be pointing out the same thing, but I noticed that in ui_g_lineplot, the default selections are hardcoded rather than dynamic to the input from tm_g_lineplot

shiny::checkboxGroupInput(
ns("table"),
label = "Choose the statistics to display in the table",
choices = c(
"n" = "n",
"Mean (SD)" = "mean_sd",
"Mean CI" = "mean_ci",
"Median" = "median",
"Median CI" = "median_ci",
"25% and 75%-ile" = "quantiles",
"Min - Max" = "range"
),
selected = c("n", "mean_sd", "median", "range"),
)

I believe Line 491 should instead be

selected = a$table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request sme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants