Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESCRIPTION file teal.report version is outdated teal.reporter (>= 0.2.0), #902

Closed
shajoezhu opened this issue Dec 1, 2023 · 6 comments · Fixed by #903
Closed

DESCRIPTION file teal.report version is outdated teal.reporter (>= 0.2.0), #902

shajoezhu opened this issue Dec 1, 2023 · 6 comments · Fixed by #903

Comments

@shajoezhu
Copy link
Contributor

          I am getting an error when testing the example
Listening on http://127.0.0.1:5913
[INFO] 2023-12-01 06:24:42.5914 pid:1924 token:[32e5f908] teal Initializing reporter_previewer_module
Warning: Error in add_card_button_srv: Assertion on 'names(formals(card_fun))' failed: Must be a subset of {'card','comment'}, but has additional elements {'label'}.
  3: runApp
  2: print.shiny.appobj
  1: <Anonymous>

Originally posted by @shajoezhu in #899 (comment)

@chlebowa
Copy link
Contributor

chlebowa commented Dec 1, 2023

Hi @shajoezhu
Could you post the example you were trying to run?

@shajoezhu
Copy link
Contributor Author

shajoezhu commented Dec 1, 2023

I was testing tm_g_lineplot example, i had a old version of teal.reporter installed. tmc build fine, but threw error. once i updated teal.report to the main, the error was gone

library(nestcolor)

adsl <- tmc_ex_adsl
adlb <- tmc_ex_adlb %>% dplyr::mutate(AVISIT == forcats::fct_reorder(AVISIT, AVISITN, min))

app <- init(
  data = cdisc_data(
    cdisc_dataset("ADSL", adsl),
    cdisc_dataset("ADLB", adlb)
  ),
  modules = modules(
    tm_g_lineplot(
      label = "Line Plot",
      dataname = "ADLB",
      strata = choices_selected(
        variable_choices(adsl, c("ARM", "ARMCD", "ACTARMCD")),
        "ARM"
      ),
      y = choices_selected(
        variable_choices(adlb, c("AVAL", "BASE", "CHG", "PCHG")),
        "AVAL"
      ),
      param = choices_selected(
        value_choices(adlb, "PARAMCD", "PARAM"),
        "ALT"
      )
    )
  )
)
if (interactive()) {
  shinyApp(ui = app$ui, server = app$server)
}

@chlebowa
Copy link
Contributor

chlebowa commented Dec 1, 2023

There have been issues with auto version bumps recently, perhaps that was the reason.

Can we close the issue?

@shajoezhu
Copy link
Contributor Author

Hi @chlebowa , I understand, but when I was checking this, it was recorded >=0.2.0 for tmc, and teal.reporter is at 0.2.1+ version already, i think the auto thing has not kicked in yet?

https://github.com/insightsengineering/teal.reporter/blob/main/DESCRIPTION
https://github.com/insightsengineering/teal.modules.clinical/blob/main/DESCRIPTION#L59

@chlebowa
Copy link
Contributor

chlebowa commented Dec 1, 2023

Ah, I see.
Looks like an oversight. Let me double check.

@chlebowa
Copy link
Contributor

chlebowa commented Dec 1, 2023

You are correct. A fix is on its way.

chlebowa added a commit that referenced this issue Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants