Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICICLE V3 #526

Merged
merged 253 commits into from
Sep 3, 2024
Merged

ICICLE V3 #526

merged 253 commits into from
Sep 3, 2024

Conversation

yshekel
Copy link
Collaborator

@yshekel yshekel commented May 23, 2024 •
edited
Loading

No description provided.

@yshekel yshekel force-pushed the yshekel/V3 branch 3 times, most recently from 9948d2f to 7ec703d Compare May 23, 2024 15:32
@yshekel yshekel changed the title Yshekel/v3 ICICLE V3 device api and vec_ops api (CPU+CUDA backend) May 23, 2024
@yshekel yshekel force-pushed the yshekel/V3 branch 7 times, most recently from 4fe29c3 to 4bb238b Compare June 2, 2024 16:09
@yshekel yshekel changed the title ICICLE V3 device api and vec_ops api (CPU+CUDA backend) ICICLE V3 (CPU+CUDA backend) Jun 5, 2024
@yshekel yshekel force-pushed the yshekel/V3 branch 2 times, most recently from 996f388 to 641c4ea Compare June 6, 2024 10:25
@yshekel yshekel marked this pull request as ready for review June 6, 2024 13:44
@yshekel yshekel force-pushed the yshekel/V3 branch 9 times, most recently from 876d52f to 07d7a24 Compare June 13, 2024 11:45
yshekel and others added 3 commits August 26, 2024 14:39
@yshekel @HadarIngonyama
use 64b type for add/mul of field elements on CPU (#588)
dfe56a7 
Co-authored-by: hadaringonyama <hadar@ingonyama.com>
@emirsoyturk @nonam3e
[FEAT] Add Mersenne to v3 (#579)
9a0766a 
## Changes

This PR adds mersenne field (m31) to icicle v3 including rust wrapper.

---------

Co-authored-by: nonam3e <timur@ingonyama.com>
@Koren-Brand @yshekel @HadarIngonyama
Koren/v3 msm (#581)
68fe909 
## Describe the changes

MSM multithreaded implementation on CPU

## Linked Issues

Resolves #

---------

Co-authored-by: Yuval Shekel <yshekel@gmail.com>
Co-authored-by: hadaringonyama <hadar@ingonyama.com>
ChickenLover
ChickenLover reviewed Aug 29, 2024
View reviewed changes
docs/docs/icicle/getting_started.md Outdated

2. **Configure the build:**
```bash
mkdir -p build && rm -rf build/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is not necessary

nonam3e and others added 4 commits August 29, 2024 16:14
@nonam3e @jeremyfelder @ChickenLover
Nonam3e/mv icicle m31 (#590)
4e27a82 
## Describe the changes

This PR moves icicle-m31 package in rust/ wrappers from rust_v3/

---------

Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: ChickenLover <romangg81@gmail.com>
@yshekel
Release script and install docs (#589)
56c605c 
This PR adds:
1. scripts to build dockers and scripts to build all release tars and deploy to github
2. documentation
3. Examples: C++ and Rust end-to-end examples regarding how to install
and use icicle
@nonam3e
fix api (#592)
fb772a4 
This PR fixes typo in v3 headers template
@yshekel
updated docs
7105132
@Otsar-Raikou
Copy link
Contributor

Regarding Documentation, currently 2 comments.

  1. would it be useful to separate pages by languages? meaning 3 separate pages for rust, go, c++
  2. Under architecture overview - the way its broken down inside (the summary) is: open, closed, extensible, multi device, and then the pages inside are cuda device, multi devce, build your own backend. Feel like this can align better

yshekel and others added 13 commits September 1, 2024 21:37
@yshekel
Fix typo for license error and updated docs (#593)
6cff54e
@Otsar-Raikou @yshekel
Made getting started first section
2772dca
@Otsar-Raikou @yshekel
Update getting_started.md
9f40278
@Otsar-Raikou
getting started edits (#595)
dc0ee9c 
Added summary on top of getting started and put getting started as the
first page under ICICLE in sidebar
@yshekel
Update README (#596)
7dbc910
@Otsar-Raikou @yshekel @jeremyfelder
Edits on README (#599)
7334047 
Co-authored-by: Yuval Shekel <yshekel@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
@Otsar-Raikou
edit intro doc(#601)
2ae1815
@ShanieWinitz
parallel ntt on cpu (#591)
6a43bde
@yshekel
pull cuda backend in release script
66a5133
@ChickenLover
Rename extension field to complex and quatric extension(#598)
d8d9e2b
@nonam3e @jeremyfelder @yshekel
V3 golang bindings (#594)
944ff9f 
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: yshekel <yshekel@gmail.com>
@jeremyfelder
[ci skip] fix docs build
36737ef
@jeremyfelder
Remove unused pages in sidebar
92ce4a0
@yshekel yshekel merged commit 5ef9ed1 into V3 Sep 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenLover ChickenLover ChickenLover left review comments

@jeremyfelder jeremyfelder jeremyfelder approved these changes

@LeonHibnik LeonHibnik Awaiting requested review from LeonHibnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@yshekel @Otsar-Raikou @ChickenLover @jeremyfelder @ShanieWinitz @Koren-Brand @emirsoyturk @mickeyasa @nonam3e @HadarIngonyama