Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #596

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Update README #596

merged 2 commits into from
Sep 2, 2024

Conversation

yshekel
Copy link
Collaborator

@yshekel yshekel commented Sep 1, 2024

cuda-backend-branch: yshekel/rename_libs

@yshekel yshekel force-pushed the yshekel/v3_root_readme branch 5 times, most recently from 693a277 to 7ef332d Compare September 1, 2024 18:54

> [!TIP]
> Try out ICICLE by running some [examples] using ICICLE in C++ and our Rust bindings
> Try out ICICLE by running some [examples](https://github.com/ingonyama-zk/icicle/tree/yshekel/V3/examples) available in C++, Rust, and Go bindings. Check out our install-and-use examples in [C++](https://github.com/ingonyama-zk/icicle/tree/yshekel/V3/examples/c%2B%2B/install-and-use-icicle), [Rust](https://github.com/ingonyama-zk/icicle/tree/yshekel/V3/examples/rust/install-and-use-icicle) and [Go](TODO)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change that to link to main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but the link will be invalid since there is no such file in main.
So either we do it and it works after merge to main or we update the link after we merge or in the final PR to main.
What do you think?

README.md Show resolved Hide resolved
@yshekel yshekel force-pushed the yshekel/v3_root_readme branch from 0c98dd0 to 0d6bf5f Compare September 2, 2024 10:50
@yshekel yshekel merged commit 7dbc910 into yshekel/V3 Sep 2, 2024
9 of 19 checks passed
@yshekel yshekel deleted the yshekel/v3_root_readme branch September 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants