Release script and install docs #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
force-pushed
the
yshekel/V3_release_and_install
branch
2 times, most recently
from
99a7ef3 to
cf05bdd
Compare
yshekel
force-pushed
the
yshekel/V3_release_and_install
branch
2 times, most recently
from
b66a6fb to
7aa5845
Compare
yshekel
force-pushed
the
yshekel/V3_release_and_install
branch
4 times, most recently
from
80da743 to
cf138aa
Compare
jeremyfelder
requested changes
Aug 29, 2024
yshekel
force-pushed
the
yshekel/V3_release_and_install
branch
from
4585d70 to
b64cc45
Compare
| std::string fileName = path.substr(path.find_last_of("/\\") + 1); | ||
|
|
||
| // Check if the library name contains "icicle" and if the path contains "/backend/" | ||
| if (fileName.find("icicle") == std::string::npos || path.find("/backend/") == std::string::npos) { |
There was a problem hiding this comment.
Does that mean that library should always be inside "/backend/" folder?
There was a problem hiding this comment.
the backend libs yes. not great but I can live with that
jeremyfelder
approved these changes
Aug 29, 2024
Co-authored-by: ChickenLover <Romangg81@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
yshekel
force-pushed
the
yshekel/V3_release_and_install
branch
from
1575751 to
e7b6ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds: