-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC blanket implementation from ibc-rs #125
Conversation
76d3bb9
to
e86e5d8
Compare
34b27d1
to
3d3b728
Compare
683587b
to
537ce1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, then all good! tnx 🙏🏻
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Co-authored-by: Farhad Shabani <Farhad.Shabani@gmail.com>
I was thinking about how to make Currently,
So even though the So, the implementation of this PR works correctly, although the logic of the implementation is wrong. Considering this, I was wondering if the fix should be in this PR or a separate one. WDYT? |
Much needed improvement! This has caused me trouble in a few spots. Each time, I got caught up with other urgent tasks and didn't get around to update it.
I'd suggest in a separate PR. |
Looks like I will wrap only that field to keep this PR wokring. The |
This PR uses gRPC blanket implementation from ibc-rs using
QueryContext
andProvableContext
traits.Todo:
ibc-rs
PR and update commit rev in this PRservice.rs
grpcurl
testsclient_status
endpoint