gRPC blanket implementation from ibc-rs

.changelog/unreleased/features/125-grpc-support-via-ibc-trait.md

@@ -0,0 +1,2 @@
+- Support gRPC services via IBC-rs trait implementation
+  ([\#125](https://github.com/informalsystems/basecoin-rs/pull/125))

Cargo.toml

@@ -12,8 +12,8 @@ base64 = { version = "0.21", default-features = false, features = ["alloc"] }
 displaydoc = { version = "0.2", default-features = false }
 derive_more = { version = "0.99.17", default-features = false, features = ["from", "into", "display"] }
 ed25519 = { version = "2.1.0", default-features = false }
-ibc = { git = "https://github.com/cosmos/ibc-rs.git", rev= "6ffe8ce" }
-ibc-proto = { version = "0.34.0", default-features = false }
+ibc = { git = "https://github.com/cosmos/ibc-rs.git", rev= "c17ff9d", features = ["grpc"] }
+ibc-proto = { version = "0.34.1", default-features = false }
 ics23 = { version = "0.10.1", default-features = false } 
 prost = { version = "0.11.6", default-features = false }
 serde = "1.0"

ci/Makefile

@@ -18,7 +18,7 @@ upgrade-client: create-channel
 	bash ~/tests/upgrade-client.sh
 	@echo "Client upgraded"
 
-grpc-service: create-channel
+grpc-service: upgrade-client
 	@echo "Testing gRPC services..."
 	bash ~/tests/grpc-service.sh
 	@echo "gRPC services working"

ci/tests/grpc-service.sh

@@ -1,50 +1,190 @@
 #!/bin/bash
 set -euo pipefail
 
-echo "Testing grpc service using grpcurl..."
+echo "Testing gRPC service using grpcurl..."
 
 # list services via gRPC reflection
+echo "List Client services via gRPC reflection."
 grpcurl -plaintext localhost:9093 list ibc.core.client.v1.Query
+echo "List Connection services via gRPC reflection."
 grpcurl -plaintext localhost:9093 list ibc.core.connection.v1.Query
+echo "List Channel services via gRPC reflection."
 grpcurl -plaintext localhost:9093 list ibc.core.channel.v1.Query
 
 # client services
+echo "ibc.core.client.v1.Query/ClientState"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.client.v1.Query/ClientState <<EOM
+{
+  "client_id": "07-tendermint-0"
+}
+EOM
+echo "ibc.core.client.v1.Query/ClientStates"
 grpcurl -plaintext localhost:9093 ibc.core.client.v1.Query/ClientStates
-grpcurl -plaintext localhost:9093 ibc.core.client.v1.Query/ConsensusStates
+echo "ibc.core.client.v1.Query/ConsensusState"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.client.v1.Query/ConsensusState <<EOM
+{
+  "client_id": "07-tendermint-0",
+  "latest_height": true
+}
+EOM
+echo "ibc.core.client.v1.Query/ConsensusStates"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.client.v1.Query/ConsensusStates <<EOM
+{
+  "client_id": "07-tendermint-0"
+}
+EOM
+echo "ibc.core.client.v1.Query/ConsensusStateHeights"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.client.v1.Query/ConsensusStateHeights <<EOM
+{
+  "client_id": "07-tendermint-0"
+}
+EOM
+echo "ibc.core.client.v1.Query/ClientStatus"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.client.v1.Query/ClientStatus <<EOM
+{
+  "client_id": "07-tendermint-0"
+}
+EOM
+# echo "ibc.core.client.v1.Query/ClientParams"
+# TODO(rano): it is unimplemented
+# grpcurl -plaintext localhost:9093 ibc.core.client.v1.Query/ClientParams
+echo "ibc.core.client.v1.Query/UpgradedClientState"
+grpcurl -plaintext localhost:9093 ibc.core.client.v1.Query/UpgradedClientState
+echo "ibc.core.client.v1.Query/UpgradedConsensusState"
+grpcurl -plaintext localhost:9093 ibc.core.client.v1.Query/UpgradedConsensusState
+
 
 # connection services
+echo "ibc.core.connection.v1.Query/Connection"
 grpcurl -plaintext -d @ localhost:9093 ibc.core.connection.v1.Query/Connection <<EOM
 {
   "connection_id": "connection-0"
 }
 EOM
+echo "ibc.core.connection.v1.Query/Connections"
 grpcurl -plaintext localhost:9093 ibc.core.connection.v1.Query/Connections
+echo "ibc.core.connection.v1.Query/ClientConnections"
 grpcurl -plaintext -d @ localhost:9093 ibc.core.connection.v1.Query/ClientConnections <<EOM
 {
   "client_id": "07-tendermint-0"
 }
 EOM
+echo "ibc.core.connection.v1.Query/ConnectionClientState"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.connection.v1.Query/ConnectionClientState <<EOM
+{
+  "connection_id": "connection-0"
+}
+EOM
+# need valid revision height
+# echo "ibc.core.connection.v1.Query/ConnectionConsensusState"
+# grpcurl -plaintext -d @ localhost:9093 ibc.core.connection.v1.Query/ConnectionConsensusState <<EOM
+# {
+#   "connection_id": "connection-0",
+#   "revision_number": 0,
+#   "revision_height": ?
+# }
+# EOM
+echo "ibc.core.connection.v1.Query/ConnectionParams"
+grpcurl -plaintext localhost:9093 ibc.core.connection.v1.Query/ConnectionParams
 
 # channel services
+echo "ibc.core.channel.v1.Query/Channel"
 grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/Channel <<EOM
 {
   "port_id": "transfer",
   "channel_id": "channel-0"
 }
 EOM
+echo "ibc.core.channel.v1.Query/Channels"
 grpcurl -plaintext localhost:9093 ibc.core.channel.v1.Query/Channels
+echo "ibc.core.channel.v1.Query/ConnectionChannels"
 grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/ConnectionChannels <<EOM
 {
   "connection": "connection-0"
 }
 EOM
+echo "ibc.core.channel.v1.Query/ChannelClientState"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/ChannelClientState <<EOM
+{
+  "port_id": "transfer",
+  "channel_id": "channel-0"
+}
+EOM
+# need valid revision height
+# echo "ibc.core.channel.v1.Query/ChannelConsensusState"
+# grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/ChannelConsensusState <<EOM
+# {
+#   "port_id": "transfer",
+#   "channel_id": "channel-0",
+#   "revision_number": 0,
+#   "revision_height": ?
+# }
+# EOM
+echo "ibc.core.channel.v1.Query/PacketCommitments"
 grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/PacketCommitments <<EOM
 {
   "port_id": "transfer",
   "channel_id": "channel-0"
 }
 EOM
+# need a valid packet sequence
+# echo "ibc.core.channel.v1.Query/PacketCommitment"
+# grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/PacketCommitment <<EOM
+# {
+#   "port_id": "transfer",
+#   "channel_id": "channel-0",
+#   "sequence": ?
+# }
+# EOM
+# echo "ibc.core.channel.v1.Query/PacketReceipt"
+# grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/PacketReceipt <<EOM
+# {
+#   "port_id": "transfer",
+#   "channel_id": "channel-0",
+#   "sequence": ?
+# }
+# EOM
+# echo "ibc.core.channel.v1.Query/PacketAcknowledgement"
+# grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/PacketAcknowledgement <<EOM
+# {
+#   "port_id": "transfer",
+#   "channel_id": "channel-0",
+#   "sequence": ?
+# }
+# EOM
+echo "ibc.core.channel.v1.Query/PacketAcknowledgements"
 grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/PacketAcknowledgements <<EOM
+{
+  "port_id": "transfer",
+  "channel_id": "channel-0",
+  "packet_commitment_sequences": []
+}
+EOM
+echo "ibc.core.channel.v1.Query/UnreceivedPackets"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/UnreceivedPackets <<EOM
+{
+  "port_id": "transfer",
+  "channel_id": "channel-0",
+  "packet_commitment_sequences": []
+}
+EOM
+echo "ibc.core.channel.v1.Query/UnreceivedAcks"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/UnreceivedAcks <<EOM
+{
+  "port_id": "transfer",
+  "channel_id": "channel-0",
+  "packet_ack_sequences": []
+}
+EOM
+echo "ibc.core.channel.v1.Query/NextSequenceReceive"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/NextSequenceReceive <<EOM
+{
+  "port_id": "transfer",
+  "channel_id": "channel-0"
+}
+EOM
+echo "ibc.core.channel.v1.Query/NextSequenceSend"
+grpcurl -plaintext -d @ localhost:9093 ibc.core.channel.v1.Query/NextSequenceSend <<EOM
 {
   "port_id": "transfer",
   "channel_id": "channel-0"

crates/app/src/abci/v0_37/impls.rs

@@ -12,7 +12,7 @@ use cosmrs::Tx;
 use ibc::Any;
 use prost::Message;
 use serde_json::Value;
-use std::fmt::Debug;
+use std::fmt::{Debug, Write};
 use tracing::{debug, info};
 
 use tendermint_proto::v0_37::abci::response_process_proposal;
@@ -269,7 +269,11 @@ pub fn commit<S: Default + ProvableStore>(app: &BaseCoinApp<S>) -> ResponseCommi
     info!(
         "Committed height {} with hash({})",
         state.current_height() - 1,
-        data.iter().map(|b| format!("{b:02X}")).collect::<String>()
+        data.iter().fold(String::new(), |mut acc, b| {
+            // write!-ing into a String can never fail
+            let _ = write!(acc, "{b:02X}");
+            acc
+        })
     );
     ResponseCommit {
         data: data.into(),