feat: core gRPC services #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 71.48% 68.28% -3.20%
==========================================
Files 124 129 +5
Lines 14979 15856 +877
==========================================
+ Hits 10707 10827 +120
- Misses 4272 5029 +757
☔ View full report in Codecov by Sentry. |
7 tasks
rnbguy
force-pushed
the
rano/grpc-services
branch
from
cf07ddc
to
67cd50b
Compare
|
Also, can you add a unclog as well? |
|
I'd like to circle in @keppel as well. It would be awesome to have your input and see if this aligns with what you've been looking for earlier. |
plafer
reviewed
Sep 11, 2023
plafer
reviewed
Sep 11, 2023
plafer
reviewed
Sep 11, 2023
rnbguy
force-pushed
the
rano/grpc-services
branch
from
40854ae
to
7b9f375
Compare
Co-authored-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com>
will be fixed in separate PR
This was referenced Sep 14, 2023
plafer
reviewed
Sep 14, 2023
Farhad-Shabani
approved these changes
Sep 14, 2023
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add grpc service dependencies * client service implementation * connection service implementation * channel service implementation * finish grpc service implementations * QueryContext under grpc feature * fix no-default-features lints * use domain types * return query block height * happy lint * immut router in validate * client and connection param service * implement upgrade service * fix upgrade context * rename struct fields and generics * remove UpgradeValidationContext trait bound * cargo fmt and clippy * add ProvableContext * add proofs to client service * add proofs to connection service * add proofs to channel service * remove redundant trait method * refactor ProvableContext trait bounds * refactor service structs * add service doc * add context docs * from impl for tonic status * remove redundant map_errs * fix cargo doc lint * remove irrelevant comments * handle empty sequence list * a general variant of PackerError * polish comments and logging * remove grpc from default features * mv grpc feature gated code under service * mv files * update mod files * update prelude * happy cargo doc * happy cargo fmt * support latest_height flag * rm redundant trait method * comment on grpc feature * todo comment for pagination * update client_status query * rm redundant trait method * add changelog entry * nitpick * rm allowed_clients * update client params query * update error message Co-authored-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com> * revert immut ref on validate will be fixed in separate PR * rm tracing use * document thread-safe params * point changelog entry to issue * rm FromStr from prelude * doc strings with correct explanations * rm reexports --------- Signed-off-by: Rano | Ranadeep <ranadip.bswas@gmail.com> Co-authored-by: Philippe Laferrière <plafer@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #686
Description
This PR implements IBC core gRPC services for
ibc-rsusing context trait definitions.This implementation aimed to leverage
ValidationContextonly. But some extensions were needed. SoQueryContextis created extending the originalValidationContext.Projects using
ibc-rscan implementValidationContextandQueryContextand have IBC core gRPC services for free.A feature flag
grpcis introduced to (en/dis)able this feature accordingly.PR author checklist:
QueryContextimpl for MockContextgrpcfrom default feature setunclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.