add direct dependency on illustrations #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
changed the title
r100-stack
reviewed
Dec 19, 2023
There was a problem hiding this comment.
To confirm, would something like new Function('specifier', 'return import(specifier)') and/or /* webpackIgnore: true */ like we had before (code) not fix this issue?
mayank99
commented
Dec 19, 2023
There was a problem hiding this comment.
No, that's what we had before #1742 and it doesn't work because the illustrations don't get bundled. see https://stackblitz.com/edit/nextjs-ukqiky?file=package.json,app%2Fpage.tsx
webpackignore and/or new Function hacks are only to be used for importing from URLs (which the browser knows how to handle); that's what i was trying to explain in this comment.
r100-stack
approved these changes
Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes #1742 (comment) which happens because
ErrorPageis part of the barrel file (index.js), resulting in bundlers trying to resolve everything even if it's not used (it later gets tree-shaked)first i tried
catching these errors (a6c4039), but vite and nextjs don't respect thiscatch. so i've resorted to moving it from a peer dependency to direct dependency.this effectively undoes the breaking change, so users have one less thing to worry about. and if
ErrorPageis not used, this should not be part of the final bundle, so no real downside there.Testing
no more errors! i've done preliminary testing locally, but I plan to test in sandboxes some more, together with #1734 after this PR is merged.
Docs
added changeset. will also update migration guide after this merges.