-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically load css at runtime as fallback #1734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
force-pushed
the
mayank/auto-css
branch
from
December 14, 2023 18:08
53218f8
to
dbcce25
Compare
mayank99
requested review from
siddhantrawal and
r100-stack
and removed request for
a team
December 18, 2023 17:27
r100-stack
reviewed
Dec 18, 2023
packages/itwinui-react/src/core/ThemeProvider/ThemeProvider.tsx
Outdated
Show resolved
Hide resolved
r100-stack
approved these changes
Dec 18, 2023
mayank99
commented
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've retested this PR and #1744 via 3.2.0-dev.0
, works fine everywhere except remix. going to merge and release this now 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
styles.css
, we will set a variable--_iui-v3-loaded
. At runtime, we check for this variable and do nothing else if found.styles.css
. Many bundlers know how to resolve this, so we should be good.styles.css
from a CDN.All of this only happens when using
theme="inherit"
. TheincludeCss
prop can be used to control this behavior for other themes as well.Testing
Tested thoroughly across different bundlers/frameworks.
transpilePackages
.3.2.0-dev.0
for external testing.Docs
Added jsdocs and changeset.