Skip to content

Commit

Permalink
add direct dependency on illustrations (#1744)
Browse files Browse the repository at this point in the history
fixes build errors related to dependency not found, because ErrorPage is present in barrel file and needs to be resolvable even if not used.
  • Loading branch information
mayank99 authored Dec 19, 2023
1 parent 2b8627d commit 7de79cd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
5 changes: 5 additions & 0 deletions .changeset/gentle-worms-dance.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@itwin/itwinui-react': minor
---

`@itwin/itwinui-illustrations-react` has been made a direct dependency again, to avoid issues with bundlers attempting to bundle it even if `ErrorPage` is not used anywhere.
8 changes: 1 addition & 7 deletions packages/itwinui-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"dev:styles": "yarn build:styles --watch"
},
"dependencies": {
"@itwin/itwinui-illustrations-react": "^2.1.0",
"@floating-ui/react": "^0.26.3",
"classnames": "^2.3.2",
"react-table": "^7.8.0",
Expand All @@ -84,7 +85,6 @@
},
"devDependencies": {
"@itwin/itwinui-css": "^2.1.0",
"@itwin/itwinui-illustrations-react": "^2.1.0",
"@itwin/itwinui-variables": "3.0.0",
"@swc/cli": "^0.1.62",
"@swc/core": "^1.3.68",
Expand Down Expand Up @@ -114,15 +114,9 @@
"vite": "^4.5.1"
},
"peerDependencies": {
"@itwin/itwinui-illustrations-react": "^2.1.0",
"react": ">= 17.0.0 < 19.0.0",
"react-dom": ">=17.0.0 < 19.0.0"
},
"peerDependenciesMeta": {
"@itwin/itwinui-illustrations-react": {
"optional": true
}
},
"lint-staged": {
"*.{tsx,ts,jsx,js}": [
"prettier --write",
Expand Down

0 comments on commit 7de79cd

Please sign in to comment.