test(connector-fabric): fix v2-2-x/deploy-cc-from-typescript-source #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
takeutak
approved these changes
Mar 15, 2023
This was referenced Mar 15, 2023
sandeepnRES
approved these changes
Mar 16, 2023
jagpreetsinghsasan
approved these changes
Mar 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
The test case [1] uses the "standard" basic-asset-transfer example for verifying contract deployment functionality and in this instance, the problem was traced back to the NodeJS flavor of the contract having a transitive dependency (fabric-contract-api => winston => logform) which was probably being auto-upgraded (due to our test fixture lacking a package-lock.json or yarn.lock file) and leading to the typescript compilation of the project failing because of updates that must've been pushed into the index.d.ts file of the logform transitive dependency. The fix applied here is to just disable the lib checking of the compiler so that the typescript code of dependencies is not type-checked at all. This would be a no-go if we were talking about the code of the Cacti framework itself, but should be fine in a test fixture project which is not used in production at all and instead only exists to support the test execution. Fixes hyperledger-cacti#2322 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2322
branch
from
d15e8e5
to
dfb7278
Compare
petermetz
referenced
this pull request
in petermetz/cacti
Mar 24, 2023
Telling the typescript compiler to skip the library code check so that auto-updating dependencies don't break the test fixture chain code compilation. The root cause and the fix are equivalent as they were for: https://github.com/hyperledger/cacti/issues/2322 https://github.com/hyperledger/cacti/pull/2323 Commit SHA: dfb7278 Fixes hyperledger-cacti#2341 Also sneaking in a .gitignore change with this: there is a VSCode extension that stores local editing history of files in a .history/ sub-folder and that needs to be ignored in git otherwise it just keeps popping up in the git index which is annoying sometimes. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
referenced
this pull request
in petermetz/cacti
Apr 4, 2023
Telling the typescript compiler to skip the library code check so that auto-updating dependencies don't break the test fixture chain code compilation. The root cause and the fix are equivalent as they were for: https://github.com/hyperledger/cacti/issues/2322 https://github.com/hyperledger/cacti/pull/2323 Commit SHA: dfb7278 Fixes hyperledger-cacti#2341 Also sneaking in a .gitignore change with this: there is a VSCode extension that stores local editing history of files in a .history/ sub-folder and that needs to be ignored in git otherwise it just keeps popping up in the git index which is annoying sometimes. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case [1] uses the "standard" basic-asset-transfer example for
verifying contract deployment functionality and in this instance, the
problem was traced back to the NodeJS flavor of the contract having
a transitive dependency (fabric-contract-api => winston => logform) which
was probably being auto-upgraded (due to our test fixture lacking a
package-lock.json or yarn.lock file) and leading to the typescript
compilation of the project failing because of updates that must've been
pushed into the index.d.ts file of the logform transitive dependency.
The fix applied here is to just disable the lib checking of the compiler
so that the typescript code of dependencies is not type-checked at all.
This would be a no-go if we were talking about the code of the Cacti
framework itself, but should be fine in a test fixture project which is
not used in production at all and instead only exists to support the
test execution.
Fixes #2322
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com