test(connector-fabric): fix v2-2-x/deploy-lock-asset.test.ts #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
takeutak
approved these changes
Mar 24, 2023
jagpreetsinghsasan
approved these changes
Apr 4, 2023
Telling the typescript compiler to skip the library code check so that auto-updating dependencies don't break the test fixture chain code compilation. The root cause and the fix are equivalent as they were for: https://github.com/hyperledger/cacti/issues/2322 https://github.com/hyperledger/cacti/pull/2323 Commit SHA: dfb7278 Fixes hyperledger-cacti#2341 Also sneaking in a .gitignore change with this: there is a VSCode extension that stores local editing history of files in a .history/ sub-folder and that needs to be ignored in git otherwise it just keeps popping up in the git index which is annoying sometimes. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
petermetz/issue2341
branch
from
4d70486
to
2c5148c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telling the typescript compiler to skip the library code check so that
auto-updating dependencies don't break the test fixture chain code
compilation.
The root cause and the fix are equivalent as they were for:
https://github.com/hyperledger/cacti/issues/2322
https://github.com/hyperledger/cacti/pull/2323
Commit SHA: dfb7278
Fixes #2341
Also sneaking in a .gitignore change with this: there is a VSCode
extension that stores local editing history of files in a .history/
sub-folder and that needs to be ignored in git otherwise it just keeps
popping up in the git index which is annoying sometimes.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com