Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-fabric): fix v2-2-x/deploy-cc-from-typescript-source #2323

Merged
merged 1 commit into from
Mar 17, 2023

Commits on Mar 16, 2023

  1. test(connector-fabric): fix v2-2-x/deploy-cc-from-typescript-source

    The test case [1] uses the "standard" basic-asset-transfer example for
    verifying contract deployment functionality and in this instance, the
    problem was traced back to the NodeJS flavor of the contract having
    a transitive dependency (fabric-contract-api => winston => logform) which
    was probably being auto-upgraded (due to our test fixture lacking a
    package-lock.json or yarn.lock file) and leading to the typescript
    compilation of the project failing because of updates that must've been
    pushed into the index.d.ts file of the logform transitive dependency.
    
    The fix applied here is to just disable the lib checking of the compiler
    so that the typescript code of dependencies is not type-checked at all.
    
    This would be a no-go if we were talking about the code of the Cacti
    framework itself, but should be fine in a test fixture project which is
    not used in production at all and instead only exists to support the
    test execution.
    
    Fixes hyperledger-cacti#2322
    
    Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    petermetz committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    dfb7278 View commit details
    Browse the repository at this point in the history