[BACKPORT] #4090 #3858: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true #4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
requested review from
s8sato,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
github-actions
bot
added
the
iroha2-dev
mversic
approved these changes
Dec 11, 2023
mversic
changed the title
6r1d
previously approved these changes
Dec 11, 2023
mversic
reviewed
Dec 11, 2023
mversic
requested changes
Dec 11, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
force-pushed
the
iroha2-stable
branch
from
a7ed2c0 to
1f7e1b3
Compare
mversic
approved these changes
Dec 12, 2023
6r1d
approved these changes
Dec 12, 2023
mversic
merged commit b8d0e0e
into
hyperledger-iroha:iroha2-stable
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I deleted the need to pass the IROHA_SKIP_WASM_CHECKS while building with stable toolchain and added in CI
Linked issue
Closes #4090 #3858