Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Remove cargo fmt from the WASM Builder #3858

Closed
0x009922 opened this issue Sep 1, 2023 · 0 comments
Closed

[suggestion] Remove cargo fmt from the WASM Builder #3858

0x009922 opened this issue Sep 1, 2023 · 0 comments
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

0x009922 commented Sep 1, 2023

Description

I raised a discussion originally here: #3841 (comment)

I'm puzzled about the inclusion of cargo fmt in the build process. While it makes sense for wasm_builder to handle cargo check and cargo build due to specific rustc parameters, cargo fmt doesn't seem to need such configuration. So why is it part of the build? Is formatting not the developer's responsibility? Are there historical reasons for this design choice?

@ilchu suggested that @Arjentix might help with clarifying it.

Proposed solution

Remove cargo fmt from iroha_wasm_builder crate.

@0x009922 0x009922 added question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Sep 1, 2023
@mversic mversic removed the question Further information is requested label Oct 19, 2023
Asem-Abdelhady added a commit that referenced this issue Dec 11, 2023
…able with true (#4096)

* [fix] #4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

---------

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this issue Dec 11, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

---------

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this issue Dec 12, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

---------

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
mversic pushed a commit that referenced this issue Dec 12, 2023
… variable with true (#4135)

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
@AlexStroke AlexStroke self-assigned this Jan 11, 2024
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this issue Jan 22, 2024
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096)

* [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [fix]: delete formating from the src code

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] the check needed in building for client and cli

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] format and checking of smart contracts in CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [add] check and format in pr for dev

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] format chekck from dev and dev-pr to dev-pr-static

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [change] revert double quotes to single quotes in paths && remove the checking from dev CI

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

* [delete] unecessary print statments and stray comment from cli build.rs

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>

---------

Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

6 participants