-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Remove cargo fmt
from the WASM Builder
#3858
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
3 tasks
This was referenced Nov 29, 2023
Asem-Abdelhady
added a commit
that referenced
this issue
Dec 11, 2023
…able with true (#4096) * [fix] #4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Dec 11, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Dec 12, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
mversic
pushed a commit
that referenced
this issue
Dec 12, 2023
… variable with true (#4135) Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Jan 22, 2024
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I raised a discussion originally here: #3841 (comment)
@ilchu suggested that @Arjentix might help with clarifying it.
Proposed solution
Remove
cargo fmt
fromiroha_wasm_builder
crate.The text was updated successfully, but these errors were encountered: