Enable Iroha build on stable #4090
Labels
build
good first issue
Good for newcomers
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
mversic
added
build
good first issue
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Nov 28, 2023
…KS env variable with true
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Nov 29, 2023
…KS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
|
closed in favor of #3858 |
mversic
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Dec 8, 2023
…KS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
mversic
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Dec 8, 2023
…KS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
that referenced
this issue
Dec 11, 2023
…able with true (#4096) * [fix] #4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Dec 11, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Dec 12, 2023
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
mversic
pushed a commit
that referenced
this issue
Dec 12, 2023
… variable with true (#4135) Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
added a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Jan 22, 2024
…ss IROHA_SKIP_WASM_CHECKS env variable with true (hyperledger-iroha#4096) * [fix] hyperledger-iroha#4090: Fix having to pass IROHA_SKIP_WASM_CHECKS env variable with true Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: Fix having to pass variable IROHA_SKIP_WASM_CHECKS with checking PORFILE variable to be test Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [fix]: delete formating from the src code Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] the check needed in building for client and cli Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] format and checking of smart contracts in CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [add] check and format in pr for dev Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] format chekck from dev and dev-pr to dev-pr-static Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [revert] paths deletion in dev-pr && [fix] naming issues in dev-pr-static CIs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [change] revert double quotes to single quotes in paths && remove the checking from dev CI Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] build script from client && [delete] IROHA_SKIP_WASM_CHECKS from nix Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> * [delete] unecessary print statments and stray comment from cli build.rs Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com> --------- Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
atm when building workspace we require "nightly" rust toolchain. This is only because wasm blobs in client are being built for testing purposes. This can be bypassed with
IROHA_SKIP_WASM_CHECKS=true cargo build.Iroha should build on stable toolchain by default to ease user experience. If "nightly" is required it should be opt-in, not opt-out. Also, in CI we must make sure that all wasm tests keep running
The text was updated successfully, but these errors were encountered: