chore(ci): update deprecated GitHub API #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryjones
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
ryjones
force-pushed
the
SO
branch
2 times, most recently
from
ad1813f
to
ae072be
Compare
ryjones
force-pushed
the
SO
branch
2 times, most recently
from
e9f13d8
to
23ca171
Compare
Telling the typescript compiler to skip the library code check so that auto-updating dependencies don't break the test fixture chain code compilation. The root cause and the fix are equivalent as they were for: https://github.com/hyperledger/cacti/issues/2322 https://github.com/hyperledger/cacti/pull/2323 Commit SHA: dfb7278 Fixes #2341 Also sneaking in a .gitignore change with this: there is a VSCode extension that stores local editing history of files in a .history/ sub-folder and that needs to be ignored in git otherwise it just keeps popping up in the git index which is annoying sometimes. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
ryjones
force-pushed
the
SO
branch
2 times, most recently
from
6ab7f72
to
d56d63a
Compare
sandeepnRES
approved these changes
Apr 5, 2023
…ata sharing Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
Signed-off-by: Ry Jones <ry@linux.com>
|
I did |
@sandeepnRES My best guess is that you did a pull with merge by accident locally at some point before you did that With that said, the 2 other commits were successfully disappeared when Ry hit 'rebase and merge' (I assume) so luckily we did not mess up and duplicate the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use current version of GitHub action