Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workflows): use 4vcpu runner for weaver data sharing workflow #2369

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

sandeepnRES
Copy link
Contributor

@sandeepnRES sandeepnRES commented Apr 4, 2023

This is to resolve data sharing worklow failing for abritrary reasons.
Additionally rename weaver workflows jobs, so as to uniquely identify them by their name.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepnRES Thank you, LGTM!

Telling the typescript compiler to skip the library code check so that
auto-updating dependencies don't break the test fixture chain code
compilation.

The root cause and the fix are equivalent as they were for:
https://github.com/hyperledger/cacti/issues/2322
https://github.com/hyperledger/cacti/pull/2323
Commit SHA: dfb7278

Fixes hyperledger-cacti#2341

Also sneaking in a .gitignore change with this: there is a VSCode
extension that stores local editing history of files in a .history/
sub-folder and that needs to be ignored in git otherwise it just keeps
popping up in the git index which is annoying sometimes.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ata sharing

Signed-off-by: Sandeep Nishad <sandeep.nishad1@ibm.com>
@sandeepnRES sandeepnRES merged commit 259515b into hyperledger-cacti:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants