-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024.4.0 #114764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frenck
commented
Apr 3, 2024
•
edited
Loading
edited
fix-113982
Fix translation keys
…114084) * Fetch ServiceNotFound message from translation cache and fix super * Fix tests trace component * Fix script errors
Improve google assistant diagnostics test
Handles auth errors after the password has been sent This means we will be able to have some decent error reporting and reauth support in the future changelog: bdraco/aionut@v4.0.0...v4.1.0
* Implement diagnostic platform for APCUPSd * Put APCUPSd in gold quality scale * Revert quality scale update * Use snapshot testing for apcupsd * Prettify the code
Co-authored-by: J. Nick Koston <nick@koston.org>
…3844) * Fetch ConfigValidationError message from translation cache * Sync error logmessages with translation cache * More sync * Cleanup * Remove unrelated change * Follow up comments * Rebase and improve contructor * Improve name * Rename to MULTIPLE_INTEGRATION_CONFIG_ERRORS
* airzone_cloud: climate: add Aidoo speeds support Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * Add suggested changes Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * airzone_cloud: climate: rename _set_fan_speeds() Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * airzone_cloud: climate: drop BASE_FAN_SPEEDS Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * airzone_cloud: climate: refactor FAN_AUTO speed Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * airzone_cloud: climate: document standard speeds replacement Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * airzone_cloud: climate: fix Homekit comment Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> * airzone_cloud: climate: consistent fan speed names Instead of mixing "low", "medium" and "high" with percentages, let's use only percentages if there are more speeds. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --------- Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
frenck
requested review from
bieniu,
davet2001,
elupus,
cgarwood,
cdce8p,
mib1185,
chemelli74,
uvjustin,
dmulcahey,
OttoWinter,
OverloadUT,
edenhaus,
StevenLooman,
Kane610,
michaelarnauts,
jjlawren,
thecode and
ochlocracy
as code owners
April 3, 2024 17:10
home-assistant
bot
added
cla-signed
core
merging-to-master
This PR is merging into the RC branch and should probably change the branch to `dev`.
labels
Apr 3, 2024
joostlek
approved these changes
Apr 3, 2024
thecode
approved these changes
Apr 3, 2024
@mib1185 If you can fix this, can you make a PR against Edit: fixed! |
* Fix for URL encoding problem #102557 Fixes the problem "Cannot play media with spaces in folder names to Sonos #102557" removing the encoding of the strings in the music library. * Fix type casting problem * Update media_browser.py to fix pr check findings Added required casting for all unquote statements to avoid further casting findings in the pr checks * Update media_browser.py Checked on linting, lets give it another try * Update media_browser.py Updated ruff run * Update media_browser.py - added version run through ruff * Update media_browser.py - ruff changes * Apply ruff formatting * Update homeassistant/components/sonos/media_browser.py Co-authored-by: jjlawren <jjlawren@users.noreply.github.com> * Update homeassistant/components/sonos/media_browser.py Co-authored-by: jjlawren <jjlawren@users.noreply.github.com> * Update homeassistant/components/sonos/media_browser.py Co-authored-by: jjlawren <jjlawren@users.noreply.github.com> * Update homeassistant/components/sonos/media_browser.py Co-authored-by: jjlawren <jjlawren@users.noreply.github.com> --------- Co-authored-by: computeq-admin <51021172+computeq-admin@users.noreply.github.com> Co-authored-by: Jason Lawrence <jjlawren@users.noreply.github.com>
Kane610
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…t tests instead of `hass.components` (#114316) * Use `setup_test_component_platform` helper for sensor entity component tests instead of `hass.components` * Missing file * Fix import * Remove invalid device class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
merging-to-master
This PR is merging into the RC branch and should probably change the branch to `dev`.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.