Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugwise to v0.37.1 #113245

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Bump plugwise to v0.37.1 #113245

merged 6 commits into from
Mar 25, 2024

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 13, 2024

Proposed change

Update the plugwise-backend - https://github.com/plugwise/python-plugwise/releases/tag/v0.37.1
Also, more info: https://github.com/plugwise/python-plugwise/releases/tag/v0.37.0

plugwise/python-plugwise@v0.36.3...v0.37.1

The plugwise backend has been refactored to create more separation between the code for actual/present Plugwise devices (Anna - fw 4.x, Adam - fw 3.x and legacy Plugwise devices (Anna - fw 1.x, P1 - fw 2.x, Stretch).
For actual devices only xml-data from /core/domain_objects is collected, this should lower the data-traffic by a factor 2.
Also, any changes in the configuration will be immediately visible in the data sent to the integration.

Also, the test-fixtures have been updated to represent more recent firmware's. And unneeded fixtures have been removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bouwew bouwew closed this Mar 13, 2024
@bouwew
Copy link
Contributor Author

bouwew commented Mar 13, 2024

@frenck , Ok, you're right, creating a new PR doesn't help.

But, sorry, I have no idea how to fix this vilfo-related error, it's unrelated to the contents of this PR?

@bouwew bouwew reopened this Mar 13, 2024
@CoMPaTech
Copy link
Contributor

@frenck @bouwew could it be due to our module 'dropping' server as a dependency/requirement somehow it's not picked up with Vilfo? i.e. some underlying dependency that isn't figured out properly? Looking at @bouwew diffs that looks like the culprit, but as but Vilfo and plugwise share semver as only (as per this PR,) previous dependency?

@bouwew
Copy link
Contributor Author

bouwew commented Mar 13, 2024

The only think I can think of, in this version of the plugwise-backend I've removed the semver dependency.
Does this break the vilfo integration in some way?

@frenck
Copy link
Member

frenck commented Mar 13, 2024

The library of the vilfo integration uses semver in its code, but seems not to depend on it correctly in its library. They pin it in their Piplock, but it is not in the required packages in their package setup as it seems.

This wasn't visible before, as Plugwise pulled in the package for them. Now you've dropped it, there is nothing that provides semver for them (which CI now picks up, as there is a code reference to an none existing package anymore).

This is a bug on their end, but now triggered by this library bump.

Ideally, we should fix their package by opening an PR upstream to add the semver dependency back into their library and bump it here in Home Assistant afterwards, which will fix this PR.

../Frenck

@bouwew
Copy link
Contributor Author

bouwew commented Mar 13, 2024

@frenck Thanks for quickly diving into this!

@CoMPaTech
Copy link
Contributor

@ManneW is this something you can self pick-up or do you need one of us to try and PR against your module?

@bouwew
Copy link
Contributor Author

bouwew commented Mar 13, 2024

I've created a PR for this issue: #112098
But no response until now.

@frenck
Copy link
Member

frenck commented Mar 13, 2024

I've created a PR for this issue: #112098

I think you mean issue, not PR 😉 Anyways, that is not the right location, as this is an issue with the upstream library, not Home Assistant.

You could consider creating a PR upstream to fix the upstream package (this is the world of open source after all ❤️ )

@bouwew
Copy link
Contributor Author

bouwew commented Mar 13, 2024

Yes, good point, I'll move the Issue :)

@ManneW
Copy link
Contributor

ManneW commented Mar 14, 2024

Hi!

Sorry for the late reply 🙏

@bouwew @CoMPaTech: I'll get back to you in that other issue 🙂

Thank you, @frenck for looking into and describing the issue! 🙏

@bouwew
Copy link
Contributor Author

bouwew commented Mar 23, 2024

@ManneW when would you have time to implement one of the proposed PR's that fixes that other issue?

@ManneW ManneW mentioned this pull request Mar 23, 2024
19 tasks
@bouwew
Copy link
Contributor Author

bouwew commented Mar 24, 2024

Waiting for #114082 to be merged.

@bouwew
Copy link
Contributor Author

bouwew commented Mar 25, 2024

@ManneW All tests are pass now 😄
Thanks for fixing the dependency-issue 👍

@bouwew bouwew marked this pull request as ready for review March 25, 2024 10:11
@bouwew bouwew requested a review from frenck as a code owner March 25, 2024 10:11
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bouwew 👍

../Frenck

@frenck frenck merged commit ace21c8 into home-assistant:dev Mar 25, 2024
35 checks passed
@bouwew bouwew deleted the pw_0_37_1 branch March 25, 2024 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants