-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plugwise to v0.37.1 #113245
Bump plugwise to v0.37.1 #113245
Conversation
Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@frenck , Ok, you're right, creating a new PR doesn't help. But, sorry, I have no idea how to fix this vilfo-related error, it's unrelated to the contents of this PR? |
@frenck @bouwew could it be due to our module 'dropping' server as a dependency/requirement somehow it's not picked up with Vilfo? i.e. some underlying dependency that isn't figured out properly? Looking at @bouwew diffs that looks like the culprit, but as but Vilfo and plugwise share |
|
The library of the This wasn't visible before, as Plugwise pulled in the package for them. Now you've dropped it, there is nothing that provides This is a bug on their end, but now triggered by this library bump. Ideally, we should fix their package by opening an PR upstream to add the semver dependency back into their library and bump it here in Home Assistant afterwards, which will fix this PR. ../Frenck |
@frenck Thanks for quickly diving into this! |
@ManneW is this something you can self pick-up or do you need one of us to try and PR against your module? |
I've created a PR for this issue: #112098 |
I think you mean issue, not PR 😉 Anyways, that is not the right location, as this is an issue with the upstream library, not Home Assistant. You could consider creating a PR upstream to fix the upstream package (this is the world of open source after all ❤️ ) |
Yes, good point, I'll move the Issue :) |
Hi! Sorry for the late reply 🙏 @bouwew @CoMPaTech: I'll get back to you in that other issue 🙂 Thank you, @frenck for looking into and describing the issue! 🙏 |
@ManneW when would you have time to implement one of the proposed PR's that fixes that other issue? |
Waiting for #114082 to be merged. |
@ManneW All tests are pass now 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bouwew 👍
../Frenck
Proposed change
Update the plugwise-backend - https://github.com/plugwise/python-plugwise/releases/tag/v0.37.1
Also, more info: https://github.com/plugwise/python-plugwise/releases/tag/v0.37.0
plugwise/python-plugwise@v0.36.3...v0.37.1
The plugwise backend has been refactored to create more separation between the code for actual/present Plugwise devices (Anna - fw 4.x, Adam - fw 3.x and legacy Plugwise devices (Anna - fw 1.x, P1 - fw 2.x, Stretch).
For actual devices only xml-data from
/core/domain_objects
is collected, this should lower the data-traffic by a factor 2.Also, any changes in the configuration will be immediately visible in the data sent to the integration.
Also, the test-fixtures have been updated to represent more recent firmware's. And unneeded fixtures have been removed.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: