Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugwise backend bump breaks the HA vilfo integration #7

Closed
bouwew opened this issue Mar 13, 2024 · 2 comments · Fixed by #8
Closed

Plugwise backend bump breaks the HA vilfo integration #7

bouwew opened this issue Mar 13, 2024 · 2 comments · Fixed by #8

Comments

@bouwew
Copy link
Contributor

bouwew commented Mar 13, 2024

Please see home-assistant/core#113245

This is the error we're seeing during the testing of the above PR:

==================================== ERRORS ====================================
_________ ERROR collecting tests/components/vilfo/test_config_flow.py __________
ImportError while importing test module '/home/runner/work/core/core/tests/components/vilfo/test_config_flow.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/components/vilfo/test_config_flow.py:4: in <module>
    import vilfo
venv/lib/python3.11/site-packages/vilfo/__init__.py:5: in <module>
    from .client import (
venv/lib/python3.11/site-packages/vilfo/client.py:7: in <module>
    from semver import compare as semver_compare
E   ModuleNotFoundError: No module named 'semver'

It is caused by the plugwise-backend module removing the semver dependency in this PR, which breaks the vilfo-backend module.

Please also see frenck's comment in the Core PR.

@bouwew
Copy link
Contributor Author

bouwew commented Mar 14, 2024

As far as I understand the issue now, the install_requires in setup.cfg are not complete, semver is missing, possibly others.
I looked at the contents of requirements.txt, there seem to be too many dependencies listed?

From what I see in client.py,ipaddress, json, requests, semver and getmac are the required dependencies?

This https://docs.python.org/3/library/ tells me ipaddress and json are standard libs, so you'll only need to add semver to setup.cfg. semver ==2.13.0 I think?
And then bump the version and release :)

@frenck
Copy link
Contributor

frenck commented Mar 14, 2024

Opened a PR to address the issue: #8

@ManneW ManneW closed this as completed in #8 Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants