Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vilfo-api-client to 0.5.0 #114082

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Bump vilfo-api-client to 0.5.0 #114082

merged 2 commits into from
Mar 25, 2024

Conversation

ManneW
Copy link
Contributor

@ManneW ManneW commented Mar 23, 2024

Proposed change

Update vilfo-api-client dependency to latest version. By using the latest version of vilfo-api-client, issues with conflicting package versions should hopefully be resolved and the work with pull request #113245 should be possible to progress.

The update to the vilfo-api-client package is documented here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

By using the latest version of vilfo-api-client, issues with conflicting package versions should hopefully be resolved.
@bouwew
Copy link
Contributor

bouwew commented Mar 24, 2024

@ManneW Please run python3 -m script.gen_requirements_all to update the vilfo-backend version nr. in the HA requirements files.

Or update the HA files requirements_all.txt and requirements_test_all.txt by hand :)

With these changes, the PR should be good to transition from "draft" to a real PR.
@ManneW ManneW marked this pull request as ready for review March 24, 2024 11:00
@bouwew bouwew mentioned this pull request Mar 24, 2024
20 tasks
@TheJulianJES TheJulianJES changed the title Update vilfo-api-client dependency to latest version Bump vilfo-api-client to 0.5.0 Mar 24, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 25, 2024
@edenhaus
Copy link
Contributor

Test failure unrelated

@edenhaus edenhaus merged commit 8f0f8f9 into home-assistant:dev Mar 25, 2024
30 of 31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed dependency integration: vilfo Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants