-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Raising DataError when passing DataFrame with int columns to Dataset" #5457
Conversation
Looks good to me! I'll merge as long as @maximlt thinks that showing a warning once isn't going to be a problem for hvplot users... |
Codecov Report
@@ Coverage Diff @@
## master #5457 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 301 301
Lines 62097 62104 +7
=======================================
+ Hits 54723 54730 +7
Misses 7374 7374
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks good to me! Ready to merge @hoxbro ? |
Yes |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Reverts #5354
As it is a breaking change. It will be reverted and added in
1.16
or2.0
(whatever comes first).For now, a warning will be given when using a DataFrame with integers as column names.