Revert "Raising DataError when passing DataFrame with int columns to Dataset" #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! I'll merge as long as @maximlt thinks that showing a warning once isn't going to be a problem for hvplot users... |
Codecov Report
@@ Coverage Diff @@
## master #5457 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 301 301
Lines 62097 62104 +7
=======================================
+ Hits 54723 54730 +7
Misses 7374 7374
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good to me! Ready to merge @hoxbro ? |
|
Yes |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5354
As it is a breaking change. It will be reverted and added in
1.16or2.0(whatever comes first).For now, a warning will be given when using a DataFrame with integers as column names.