Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising DataError when passing DataFrame with int columns to Dataset #5354

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 13, 2022

Fixes #5353

Note that this PR will break hvplot tests.

@codecov-commenter
Copy link

Codecov Report

Merging #5354 (8783487) into master (5ce1e1d) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #5354   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         301      301           
  Lines       61957    61957           
=======================================
  Hits        54567    54567           
  Misses       7390     7390           
Impacted Files Coverage Δ
holoviews/core/data/pandas.py 93.40% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce1e1d...8783487. Read the comment docs.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing DataFrame with int columns to Dataset
3 participants