Skip to content

Commit

Permalink
Raising DataError when passing int columns DataFrame to Dataset (#5354)
Browse files Browse the repository at this point in the history
  • Loading branch information
hoxbro authored Sep 24, 2022
1 parent b61987a commit 7e3ec26
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions holoviews/core/data/pandas.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ def init(cls, eltype, data, kdims, vdims):
elif kdims == [] and vdims is None:
vdims = list(data.columns[:nvdim if nvdim else None])

if any(isinstance(d, (np.int64, int)) for d in kdims+vdims):
raise DataError("pandas DataFrame column names used as dimensions "
"must be strings not integers.", cls)
# Handle reset of index if kdims reference index by name
for kd in kdims:
kd = dimension_name(kd)
Expand All @@ -64,9 +67,6 @@ def init(cls, eltype, data, kdims, vdims):
for name in index_names):
data = data.reset_index()
break
if any(isinstance(d, (np.int64, int)) for d in kdims+vdims):
raise DataError("pandas DataFrame column names used as dimensions "
"must be strings not integers.", cls)

if kdims:
kdim = dimension_name(kdims[0])
Expand Down

0 comments on commit 7e3ec26

Please sign in to comment.