Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include solo and pooled stackers in signer stacker endpoints #1987

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Jun 3, 2024

Closes #1953

Include pooled and solo stackers in the pox signer endpoints.

  • The properties solo_stacker_count and pooled_stacker_count added to /extended/v2/pox/cycles/:cycle_number/signers and /extended/v2/pox/cycles/:cycle_number/signers/:signer_key
  • The /extended/v2/pox/cycles/:cycle_number/signers/:signer_key/stackers endpoint now returns the list of all stackers (both pooled and solo), and a stacker_type: 'solo' | 'pooled' field.

Copy link

github-actions bot commented Jun 3, 2024

Vercel deployment URL: https://stacks-blockchain-a6ndmbxne-blockstack.vercel.app 🚀

@zone117x zone117x requested review from rafaelcr and janniks June 3, 2024 13:58
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.54%. Comparing base (34a8454) to head (3f5408f).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1987    +/-   ##
=========================================
  Coverage    72.54%   72.54%            
=========================================
  Files           94       94            
  Lines        12586    12586            
  Branches      2937     2878    -59     
=========================================
  Hits          9130     9130            
- Misses        3294     3438   +144     
+ Partials       162       18   -144     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/datastore/common.ts Show resolved Hide resolved
src/datastore/pg-store-v2.ts Outdated Show resolved Hide resolved
src/datastore/pg-store-v2.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@zone117x zone117x requested a review from BLuEScioN June 4, 2024 10:45
src/datastore/pg-store-v2.ts Outdated Show resolved Hide resolved
@zone117x zone117x requested a review from janniks June 4, 2024 15:48
Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@zone117x zone117x merged commit 302a5d8 into develop Jun 5, 2024
30 checks passed
@zone117x zone117x deleted the feat/signer-stacker-counts branch June 5, 2024 09:22
blockstack-devops pushed a commit that referenced this pull request Jun 5, 2024
## [7.11.0-beta.8](v7.11.0-beta.7...v7.11.0-beta.8) (2024-06-05)

### Features

* include solo and pooled stackers in signer stacker endpoints ([#1987](#1987)) ([302a5d8](302a5d8))

### Bug Fixes

* ensure events are inserted into the raw event request table ([#1925](#1925)) ([34a8454](34a8454))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.11.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Jun 7, 2024
## [7.11.0](v7.10.0...v7.11.0) (2024-06-07)

### Features

* add average stacks block time to burn block endpoints ([#1963](#1963)) ([31c2eed](31c2eed))
* add burn_block_height to Rosetta endpoints ([#1974](#1974)) ([9648ac8](9648ac8))
* add burn_block_height to transactions ([#1969](#1969)) ([3e2d524](3e2d524))
* add signer_address to pox signer endpoints ([#1975](#1975)) ([7d3444b](7d3444b))
* add total tx count to burn block endpoints ([#1965](#1965)) ([d38b78a](d38b78a))
* average block times endpoint ([#1962](#1962)) ([cd151aa](cd151aa))
* docker build for arm ([#1947](#1947)) ([2c526fc](2c526fc))
* include solo and pooled stackers in signer stacker endpoints ([#1987](#1987)) ([302a5d8](302a5d8))
* support multiple STX faucet source accounts ([#1946](#1946)) ([be5db0c](be5db0c))
* support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c))

### Bug Fixes

* ensure events are inserted into the raw event request table ([#1925](#1925)) ([34a8454](34a8454))
* inconsistent block transaction results in Rosetta response ([#1958](#1958)) ([a5bec61](a5bec61))
* issue with block_time receipt not being written to db ([#1961](#1961)) ([74c06c6](74c06c6))
* pox4 properties missing in various endpoints ([#1977](#1977)) ([521d771](521d771))
* rosetta account endpoint should assume chain tip if block not specified ([#1956](#1956)) ([4bba526](4bba526))
* signer stacker query using string instead of int for cycle_id ([#1991](#1991)) ([5ce9b44](5ce9b44))
* socket-io client must only use websocket transport ([#1976](#1976)) ([85ea5af](85ea5af))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add number of stackers to /pox/cycles/{cycle_number} endpoint
5 participants