Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a few pox4 properties missing in various endpoints #1977

Merged
merged 1 commit into from
May 14, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented May 13, 2024

Closes #1978

A few pox endpoints are missing some new pox4 data.

For example signer_key, end_cycle_id, and start_cycle_id missing from /extended/v1/pox4/stacker/<address>.

And stacked_amount missing for pool addresses in the /extended/v2/pox/cycles/<id>/signers/<key>/stackers endpoint.

@zone117x zone117x requested a review from rafaelcr May 13, 2024 15:07
@zone117x zone117x self-assigned this May 13, 2024
Copy link

Vercel deployment URL: https://stacks-blockchain-7kqsyo77y-blockstack.vercel.app 🚀

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.53%. Comparing base (7d3444b) to head (865a1a1).

Files Patch % Lines
src/api/routes/v2/helpers.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1977      +/-   ##
===========================================
+ Coverage    72.39%   72.53%   +0.14%     
===========================================
  Files           94       94              
  Lines        12579    12585       +6     
  Branches      2873     2878       +5     
===========================================
+ Hits          9106     9129      +23     
+ Misses        3455     3438      -17     
  Partials        18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone117x zone117x removed their assignment May 13, 2024
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zone117x zone117x merged commit 521d771 into develop May 14, 2024
31 checks passed
@zone117x zone117x deleted the fix/pox4-res-missing-props branch May 14, 2024 08:11
blockstack-devops pushed a commit that referenced this pull request May 14, 2024
## [7.11.0-beta.7](v7.11.0-beta.6...v7.11.0-beta.7) (2024-05-14)

### Features

* add burn_block_height to Rosetta endpoints ([#1974](#1974)) ([9648ac8](9648ac8))
* add signer_address to pox signer endpoints ([#1975](#1975)) ([7d3444b](7d3444b))

### Bug Fixes

* pox4 properties missing in various endpoints ([#1977](#1977)) ([521d771](521d771))
* socket-io client must only use websocket transport ([#1976](#1976)) ([85ea5af](85ea5af))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.11.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Jun 7, 2024
## [7.11.0](v7.10.0...v7.11.0) (2024-06-07)

### Features

* add average stacks block time to burn block endpoints ([#1963](#1963)) ([31c2eed](31c2eed))
* add burn_block_height to Rosetta endpoints ([#1974](#1974)) ([9648ac8](9648ac8))
* add burn_block_height to transactions ([#1969](#1969)) ([3e2d524](3e2d524))
* add signer_address to pox signer endpoints ([#1975](#1975)) ([7d3444b](7d3444b))
* add total tx count to burn block endpoints ([#1965](#1965)) ([d38b78a](d38b78a))
* average block times endpoint ([#1962](#1962)) ([cd151aa](cd151aa))
* docker build for arm ([#1947](#1947)) ([2c526fc](2c526fc))
* include solo and pooled stackers in signer stacker endpoints ([#1987](#1987)) ([302a5d8](302a5d8))
* support multiple STX faucet source accounts ([#1946](#1946)) ([be5db0c](be5db0c))
* support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c))

### Bug Fixes

* ensure events are inserted into the raw event request table ([#1925](#1925)) ([34a8454](34a8454))
* inconsistent block transaction results in Rosetta response ([#1958](#1958)) ([a5bec61](a5bec61))
* issue with block_time receipt not being written to db ([#1961](#1961)) ([74c06c6](74c06c6))
* pox4 properties missing in various endpoints ([#1977](#1977)) ([521d771](521d771))
* rosetta account endpoint should assume chain tip if block not specified ([#1956](#1956)) ([4bba526](4bba526))
* signer stacker query using string instead of int for cycle_id ([#1991](#1991)) ([5ce9b44](5ce9b44))
* socket-io client must only use websocket transport ([#1976](#1976)) ([85ea5af](85ea5af))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pox4 data from a few endpoints
3 participants