Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docker build for arm #1947

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

pradel
Copy link
Contributor

@pradel pradel commented Apr 16, 2024

Description

I added arm docker builds support so I can run a node on my arm server. Right now you will get an error when trying to run the amd image on an arm server. The work was already started on other prs but never merged. I followed the approach mentioned in #1578 to keep amd build only on prs to not increase the build time and build both arm + amd on the master branch.

Following up the following prs:

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @rafaelcr or @zone117x for review

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pradel!

@zone117x zone117x merged commit 2c526fc into hirosystems:develop Apr 16, 2024
28 of 30 checks passed
@pradel pradel deleted the feat/docker-arm-build branch April 16, 2024 15:37
blockstack-devops pushed a commit that referenced this pull request Apr 16, 2024
## [7.11.0-beta.2](v7.11.0-beta.1...v7.11.0-beta.2) (2024-04-16)

### Features

* docker build for arm ([#1947](#1947)) ([2c526fc](2c526fc))
* support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.11.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Jun 7, 2024
## [7.11.0](v7.10.0...v7.11.0) (2024-06-07)

### Features

* add average stacks block time to burn block endpoints ([#1963](#1963)) ([31c2eed](31c2eed))
* add burn_block_height to Rosetta endpoints ([#1974](#1974)) ([9648ac8](9648ac8))
* add burn_block_height to transactions ([#1969](#1969)) ([3e2d524](3e2d524))
* add signer_address to pox signer endpoints ([#1975](#1975)) ([7d3444b](7d3444b))
* add total tx count to burn block endpoints ([#1965](#1965)) ([d38b78a](d38b78a))
* average block times endpoint ([#1962](#1962)) ([cd151aa](cd151aa))
* docker build for arm ([#1947](#1947)) ([2c526fc](2c526fc))
* include solo and pooled stackers in signer stacker endpoints ([#1987](#1987)) ([302a5d8](302a5d8))
* support multiple STX faucet source accounts ([#1946](#1946)) ([be5db0c](be5db0c))
* support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c))

### Bug Fixes

* ensure events are inserted into the raw event request table ([#1925](#1925)) ([34a8454](34a8454))
* inconsistent block transaction results in Rosetta response ([#1958](#1958)) ([a5bec61](a5bec61))
* issue with block_time receipt not being written to db ([#1961](#1961)) ([74c06c6](74c06c6))
* pox4 properties missing in various endpoints ([#1977](#1977)) ([521d771](521d771))
* rosetta account endpoint should assume chain tip if block not specified ([#1956](#1956)) ([4bba526](4bba526))
* signer stacker query using string instead of int for cycle_id ([#1991](#1991)) ([5ce9b44](5ce9b44))
* socket-io client must only use websocket transport ([#1976](#1976)) ([85ea5af](85ea5af))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants