Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Prettify .xib launch screen #3951

Closed
bengtan opened this issue Jul 30, 2019 · 3 comments
Closed

[ios] Prettify .xib launch screen #3951

bengtan opened this issue Jul 30, 2019 · 3 comments

Comments

@bengtan
Copy link
Contributor

bengtan commented Jul 30, 2019

With the work-around for #3926/#3943/PR #3944, I caused an ugly-ish interstitial to appear in the splash screen process. The interstitial is ios/TinyRobot/Base.lproj/LaunchScreen.xib.

Please prettify the xib file.
southerneer added a commit that referenced this issue Jul 30, 2019
@southerneer
hide SplashScreen from Launch (#3743), fix Launch screen (#3951) (#3948)
2c47b63 
hide SplashScreen from Launch (#3743), fix Launch screen (#3951)
@bengtan
Copy link
Contributor Author

bengtan commented Jul 31, 2019

QA notes: Verify that the interstitial/intermediate splash screen which says 'Tinyrobot' and 'Powered by React Native' no longer appears.

@mstidham
Copy link

mstidham commented Aug 1, 2019

Verified on Staging Version: 4.19.1

@mstidham
Copy link

Verified on Prod Version: 4.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bengtan @mstidham