Loading screen missing

[mstidham]

Loading screen missing

QA TEMPLATE	Input
Device Type:	iPhone 7 Plus & Samsung S7
iOS:	12.2
tr Version:	4.11.0
Environment	Staging
Codepush:
Internet Connection Type:	WiFi
Users affected?	Miranda
User handle:	@miranda
Bypass handle?:	@TestyTester (191-9191)
Location access type?	Always
Does this issue occur on other environments?
Time issue occurred (UTC)

Observed Result:

When opening the app on android device I do not see the loading screen. I only have a blank white screen until the HS loads. On ios I see the loading screen for an instant and then see a white blank screen until HS loads.

Expected Result:

User shouldn't see blank white screen, it should display the loading screen.

Steps to reproduce:

1. Kill the app and reload after user has been logged in.

Related Screenshots/Video Links:

---

[southerneer]

I think this broke after Pavel's recent router tweaks.

[aksonov]

@mstidham Could you find out when this bug started to occur? Video would be useful as well.

@southerneer At this moment I can't find relation between removing of extra-stack and intermediate white screen..

As far as I see it could be react native issue - i.e. after iOS launch screen and before react native root view UI:
https://stackoverflow.com/questions/49639287/is-there-a-way-to-avoid-the-white-flash-with-react-native

[aksonov]

Found another receipt from facebook:
https://facebook.github.io/react-native/docs/running-on-device.html#pro-tip

The possible reason of white screen is explained there - "As your App Bundle grows in size, you may start to see a white screen flash between your splash screen and the display of your root application view. "

I will try it tomorrow

[mstidham]

This is probably not needed now but I see this issue on 4.10.0, 4.11.0 & 4.12.0
https://app.box.com/s/ziaxvrp5v02xz02tfuaxdzmipejaa65p

[bengtan]

The PR that was merged for this ticket may not necessarily fix this ticket, though it should improve it. I guess we'll find out via QA.

[mstidham]

Version: 4.13.0
It's an improvement but still briefly seeing the blank white screen.
https://app.box.com/s/cjr3mh4t8ncrmorg3zd2hbktd3s2y10n

[southerneer]

Hmm, @aksonov from that video it looks like the launch screen is coming up immediately (good), but for the delay while the app is connecting and setting up the profile it shows a blank screen. Maybe move SplashScreen.hide() to componentDidMount of OnboardingSlideShow and Home? Or maybe there's a cleaner way to do that in Router.tsx?

[aksonov]

Oh, it is weird, need to investigate what white screen is shown...

[bengtan]

@aksonov:

My findings at:

rn-splash-screen triggers background crash #3943
PR #3944

may change what you do in this ticket.

[bengtan]

Quickly tested this since I did PR #3944 which might have changed things.

I (still) see a brief white white screen on 4.18.2 (both android and iOS).

Interesting, since it occurs after the iOS splash screen (newly introduced by 3944 and which says 'Tinyrobot' and 'Powered by React Native'), that suggests it's happening as part of React Native initialisation. Well, maybe. I'm speculating.

[mstidham]

Staging Version: 4.19.1
I'm still seeing white screen before the HS loads.

https://app.box.com/s/erhjm2yz20frbsq4d451nwjlc8lu1u9u

[southerneer]

Ok, it sounds like we've regressed back to this problem.

[mstidham]

Codepush StagingBeng

I'm seeing the white screen again on regular account. I had previously verified this via Pavel's codepush on a bypass account but wanted to post results regarding StagingBeng codepush and my regular account.

Regular account (@miranda)
Video: https://app.box.com/s/5oa6x8s5l7ujto307aio53kmy45nff95

Bypass account (@TestyTester)
Video: https://app.box.com/s/0nevu5c42tnh7hnxgbepq4207kwvpuay

[aksonov]

Do you see white screen on my code push?

…

On 13 Aug 2019, at 18:58, mstidham ***@***.***> wrote: Codepush StagingBeng I'm seeing the white screen again on regular account. I had previously verified this via Pavel's codepush on a bypass account but wanted to post results regarding StagingBeng codepush and my regular account. Regular account ***@***.*** <https://github.com/miranda>) Video: https://app.box.com/s/5oa6x8s5l7ujto307aio53kmy45nff95 <https://app.box.com/s/5oa6x8s5l7ujto307aio53kmy45nff95> Bypass account ***@***.*** <https://github.com/TestyTester>) Video: https://app.box.com/s/0nevu5c42tnh7hnxgbepq4207kwvpuay <https://app.box.com/s/0nevu5c42tnh7hnxgbepq4207kwvpuay> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3743?email_source=notifications&email_token=AAKCS4MJDRO2MXYYUZGPMB3QELK2FA5CNFSM4HNV7PI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GEAFY#issuecomment-520896535>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKCS4JXGAYSEILAAM2ZCQTQELK2FANCNFSM4HNV7PIQ>.

[mstidham]

@aksonov I just installed your codepush and I do not see white screen.

[aksonov]

Great. Beng’s codepush is only about battery usage. All other tickets should not be tested.

…

On 13 Aug 2019, at 19:21, mstidham ***@***.***> wrote: @aksonov <https://github.com/aksonov> I just installed your codepush and I do not see white screen. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3743?email_source=notifications&email_token=AAKCS4NE7ONWDKRET2ANRD3QELNSFA5CNFSM4HNV7PI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GGGJI#issuecomment-520905509>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKCS4LXCB2RRY5BVZHY2KTQELNSFANCNFSM4HNV7PIQ>.

[mstidham]

@aksonov see comment on #3915

[aksonov]

Oops, never mind then. Probably Beng didn’t merge my PR, but include it into changelog

…

On 13 Aug 2019, at 19:26, mstidham ***@***.***> wrote: @aksonov <https://github.com/aksonov> see comment on #3915 <#3915> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3743?email_source=notifications&email_token=AAKCS4NVKAI3LAAHJ5U3MHLQELOC5A5CNFSM4HNV7PI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GGTJA#issuecomment-520907172>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKCS4PKOZYTE4M4ZXRHLRLQELOC5ANCNFSM4HNV7PIQ>.

[bengtan]

@aksonov:

Probably Beng didn’t merge my PR, but include it into changelog

Hmmm ... the codepush I prepared for Miranda is commit d940a25 which does include PR #3986.

I can't explain why apparently #3743 occurs again with my codepush.

---

Oh, actually, I can.

When I did the codepush, I didn't do yarn install so it's still using the old RNRF (4.1.0-beta.5).

My mistake. Sorry for the false alarm.

[mstidham]

Verified on Prod Version: 4.20.0 closing ticket.