Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide SplashScreen from Launch (#3743), fix Launch screen (#3951) #3948

Merged
merged 3 commits into from
Jul 30, 2019
Merged

hide SplashScreen from Launch (#3743), fix Launch screen (#3951) #3948

merged 3 commits into from
Jul 30, 2019

Conversation

aksonov
Copy link
Contributor

@aksonov aksonov commented Jul 29, 2019

No description provided.

@aksonov
Copy link
Contributor Author

aksonov commented Jul 29, 2019

This ticket is not visible yet because of #3926 @bengtan's fix. I tried to reproduce and fix that crash, but unsuccessfully.

@aksonov aksonov changed the title hide SplashScreen from Launch (#3743) WIP: hide SplashScreen from Launch (#3743) Jul 29, 2019
@aksonov
Copy link
Contributor Author

aksonov commented Jul 29, 2019

Tomorrow I will try to move our launch image into .xib file, so app starts working again correctly

@aksonov aksonov changed the title WIP: hide SplashScreen from Launch (#3743) hide SplashScreen from Launch (#3743), fix Launch screen (#3951) Jul 30, 2019
@aksonov aksonov requested a review from southerneer July 30, 2019 15:32
@southerneer
Copy link
Contributor

iOS build failed on AppCenter. Logs don't point to anything in particular. I ran locally and it built fine so I'm going to review + merge.

southerneer
southerneer approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@southerneer southerneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review that's readable, but it builds so I'll pass it along to QA

@southerneer southerneer merged commit 2c47b63 into master Jul 30, 2019
@southerneer southerneer deleted the 3743 branch July 30, 2019 19:24
@bengtan
Copy link
Contributor

bengtan commented Jul 31, 2019

iOS build failed on AppCenter.

After merging, iOS AppCenter built successfully on master. shrugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southerneer southerneer southerneer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aksonov @southerneer @bengtan