Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-server): simplify route tree utils #338

Merged
merged 16 commits into from
Jun 4, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jun 3, 2024

Picking up some code from

Preparing for

The idea is to extract routing logic (fs route tree generation + route matching) out of react-server world, so it can be used anywhere as a pure utility. This also helps test-ability.

@hi-ogawa hi-ogawa changed the title refactor(react-server): organize route tree utils refactor(react-server): simplify route tree utils Jun 3, 2024
@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jun 4, 2024

Merge activity

  • Jun 3, 11:09 PM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.
  • Jun 3, 11:09 PM EDT: @hi-ogawa merged this pull request with Graphite.

@hi-ogawa hi-ogawa merged commit 85fe160 into main Jun 4, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the refactor-route-utils branch June 4, 2024 03:09
hi-ogawa added a commit that referenced this pull request Jun 4, 2024
- supersedes #257

Probably I should rework/refactor route tree manipulation first. 

- [x] refactor tree utils (separated in #338)
- [x] preload from ssr
- [ ] preload from browser
- [ ] preload css
- [ ] preload during dev?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant