Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-server): fix client css FOUC #342

Merged
merged 4 commits into from
Jun 4, 2024
Merged

fix(react-server): fix client css FOUC #342

merged 4 commits into from
Jun 4, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jun 4, 2024

It looks like I haven't test this case and it turns out I get FOUC (both dev and build), which needs to be fixed before thinking about preload.

For build, <link rel="stylesheet" ... /> is injected during preload. We need to take control of that probably https://github.com/vitejs/vite/blob/147e9228bb1c75db153873761eb7a120a2bd09a4/packages/vite/src/node/plugins/importAnalysisBuild.ts#L119-L129

todo

@hi-ogawa hi-ogawa force-pushed the feat-css-preload branch from 7030d41 to b541e7b Compare June 4, 2024 03:15
@hi-ogawa hi-ogawa changed the title test(react-server): add client css demo fix(react-server): fix client css FOUC Jun 4, 2024
@hi-ogawa hi-ogawa force-pushed the feat-css-preload branch from b541e7b to 764d5d1 Compare June 4, 2024 03:27
@hi-ogawa hi-ogawa force-pushed the feat-css-preload branch from 764d5d1 to 201b0f3 Compare June 4, 2024 03:43
@hi-ogawa hi-ogawa marked this pull request as ready for review June 4, 2024 04:01
@hi-ogawa hi-ogawa force-pushed the feat-css-preload branch from 201b0f3 to ea81871 Compare June 4, 2024 05:49
@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Jun 4, 2024

Merge activity

  • Jun 4, 2:06 AM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.
  • Jun 4, 2:07 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 4, 2:08 AM EDT: @hi-ogawa merged this pull request with Graphite.

Base automatically changed from feat-css-preload to main June 4, 2024 06:07
hi-ogawa added a commit that referenced this pull request Jun 4, 2024
Need to fix client css first
- #342
@hi-ogawa hi-ogawa merged commit 2217cd6 into main Jun 4, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the fix-client-css branch June 4, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant