-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-server): preload client references #257
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c600c54.
I'm hesitant to land this feature, so let's split a bit
|
1 task
4 tasks
This will be superseded by Put this in draft for now |
This was referenced Jun 3, 2024
hi-ogawa
added a commit
that referenced
this pull request
Jun 4, 2024
…#331) - related #257 Looking back #257, the manifest manipulation looks to complicated, so I'm trying a new approach here. ## todo - build time - [x] use `transform.meta` and `PluginContext.getModuleInfo` to map from route to client reference (during server build) - [x] map client reference id to browser asset file (during browser build) - runtime - [ ] this is probably unavoidable and just need to copy #257 separate PR? - [ ] test
hi-ogawa
added a commit
that referenced
this pull request
Jun 4, 2024
hi-ogawa
added a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo screenshot
The bottom one shows hovering
/test/deps
is triggering client reference assets before fetching rsc.todo 2
resolveId
importer? I feel we shouldn't technically need lazy import glob to get this featuretodo
preload
api?chunks
?preload
api? https://react.dev/reference/react-dom/preloadclient-reference.js
andreact-server-dom-webpack/client.browser
)