Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Trouble with Node > 10 #6

Closed
tschaub opened this issue May 1, 2019 · 2 comments
Closed

Trouble with Node > 10 #6

tschaub opened this issue May 1, 2019 · 2 comments

Comments

@tschaub
Copy link

tschaub commented May 1, 2019

I haven't been able to nail down the specifics, but it looks like this module fails (as used by JSDoc) on Node > 10, perhaps only on linux.

See jsdoc/jsdoc#1530 (comment) for one report.

We're seeing CI failures with this stack:

/home/circleci/repo/node_modules/requizzle/lib/requizzle.js:45
	if (lookupPaths[0] === targetPath && lookupPaths[1].length === 0) {
	               ^

TypeError: Cannot read property '0' of null
    at isNativeModule (/home/circleci/repo/node_modules/requizzle/lib/requizzle.js:45:17)
    at Requizzle.requizzle (/home/circleci/repo/node_modules/requizzle/lib/requizzle.js:82:6)
    at infectProxy (/home/circleci/repo/node_modules/requizzle/lib/loader.js:82:28)
    at Module.targetModule.require (/home/circleci/repo/node_modules/requizzle/lib/loader.js:101:11)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/circleci/repo/node_modules/jsdoc/lib/jsdoc/fs.js:7:10)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Object.load (/home/circleci/repo/node_modules/requizzle/lib/loader.js:112:15)

I'll try to get more detail.

@hegemonic
Copy link
Owner

This should be working on master thanks to #4. New release (of this package and JSDoc) later this week, hopefully. Apologies for the breakage and delay.

@tschaub
Copy link
Author

tschaub commented May 1, 2019

Thanks @hegemonic.

siberex added a commit to scalio/rules_nodejs that referenced this issue Oct 29, 2019
jsdoc peer dependency `requizzle` is failing due to this:
hegemonic/requizzle#6
alexeagle pushed a commit to bazel-contrib/rules_nodejs that referenced this issue Oct 30, 2019
* fix(jasmine): fix dynamic import test

for extensionless imports nearest parent package.json should contain a
top-level field "type":
https://nodejs.org/docs/latest-v12.x/api/esm.html#esm_enabling

* fix(examples): loosen node version requirement to include 12 LTS

* fix(labs): bump dependency versions

jsdoc peer dependency `requizzle` is failing due to this:
hegemonic/requizzle#6

* fix(labs): unpin protobufjs dependency version from commit sha to latest

* fix(labs): match @bazel/labs protobufjs dependencies with protobuf.js 6.8.8 deps

in other case protobuf.js will try to npm install mismatched dependency
versions programmatically and fail due to read-only sandbox fs:

https://github.com/protobufjs/protobuf.js/blob/69623a91c1e4a99d5210b5295a9e5b39d9517554/cli/util.js#L129
https://github.com/protobufjs/protobuf.js/blob/69623a91c1e4a99d5210b5295a9e5b39d9517554/package.json

* fix(labs): freeze protobufjs version in place

other dependencies here should have the same major version as in protobufjs package.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants