Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Future proof #4

Merged
merged 2 commits into from
May 1, 2019
Merged

Future proof #4

merged 2 commits into from
May 1, 2019

Conversation

BridgeAR
Copy link
Contributor

@BridgeAR BridgeAR commented Apr 5, 2019

This updates the call to _resolveLookupPaths. It returns a string
by default since Node.js v8 when called with a third truthy argument.
The backwards compatible return value should change soon, so detect
what return type is used and handle both cases.

Refs: nodejs/node#26983


This module uses a lot of Node.js internal functions. Something that recently changed is the wrapper and it is now auto detected if a module manipulates the wrapper or not. If that's the case, a compatibility mode is used instead of the regular file loading mechanism currently in place. It would be great if a different solution could be found than manipulating the wrapper (or the wrapper function).

BridgeAR added 2 commits April 6, 2019 18:58
This updates the call to _resolveLookupPaths. It returns a string
by default since Node.js v8 when called with a third truthy argument.
The backwards compatible return value should change soon, so detect
what return type is used and handle both cases.

Refs: nodejs/node#26983
@BridgeAR
Copy link
Contributor Author

BridgeAR commented Apr 8, 2019

@hegemonic PTAL

@jgravois jgravois mentioned this pull request Apr 24, 2019
@ghost ghost mentioned this pull request Apr 25, 2019
4 tasks
@ghost
Copy link

ghost commented Apr 25, 2019

@hegemonic:Would you mind approving this so as to fix it for Nodejs 12? Thanks!

@shinnn shinnn mentioned this pull request Apr 25, 2019
5 tasks
@hegemonic
Copy link
Owner

Thanks for the pull request, and apologies for the delay in reviewing it. I'll release a new version of this module soon, followed by a new version of JSDoc. (I'm a bit swamped, so I might need a few days to finish all of that.)

And you're right, this module is a horrible hack (although you were nice enough not to put it that way). JSDoc ran on Mozilla Rhino before it ran on Node.js, and this module helped bridge the gap between the two. I'm working (very slowly) on a long-term solution, so JSDoc doesn't have to do awful things to the module loader. Unfortunately, that will break lots of stuff, but it's the right thing to do nonetheless.

@hegemonic hegemonic merged commit cb74458 into hegemonic:master May 1, 2019
@hegemonic hegemonic mentioned this pull request May 1, 2019
@hegemonic
Copy link
Owner

FYI, I released an updated version of requizzle that includes this fix. JSDoc 3.6.0 also includes the fix.

keggsmurph21 added a commit to keggsmurph21/ud-annotatrix that referenced this pull request Apr 26, 2021
Apparently, 4.x was broken on newer versions of `node`.  See this[1]
issue for details.

Anyways, as of this commit we should build :^)

[1] hegemonic/requizzle#4
jonorthwash pushed a commit to jonorthwash/ud-annotatrix that referenced this pull request Jun 10, 2021
Apparently, 4.x was broken on newer versions of `node`.  See this[1]
issue for details.

Anyways, as of this commit we should build :^)

[1] hegemonic/requizzle#4
jonorthwash pushed a commit to jonorthwash/ud-annotatrix that referenced this pull request Jun 11, 2021
Apparently, 4.x was broken on newer versions of `node`.  See this[1]
issue for details.

Anyways, as of this commit we should build :^)

[1] hegemonic/requizzle#4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants