chore: update NodeJS to LTS 12.13.0 and yarn to 1.19.1 version #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siberex
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
for extensionless imports nearest parent package.json should contain a top-level field "type": https://nodejs.org/docs/latest-v12.x/api/esm.html#esm_enabling
|
let's just pin that protocol buffers example back to v10 if it's not trivial to fix it, so we can roll this out. Thanks! |
|
Looks like that one could be solved by upgrading dependencies for |
jsdoc peer dependency `requizzle` is failing due to this: hegemonic/requizzle#6
|
FYI I mirrored the four new files to the bazel-mirror URL |
|
Failure is looks like the action wants to write to the node_modules which is probably a read-only filesystem. Do you know what we need to install to prevent protobufjs doing this? |
|
Issue is that I don't know how to deal with it yet |
… 6.8.8 deps in other case protobuf.js will try to npm install mismatched dependency versions programmatically and fail due to read-only sandbox fs: https://github.com/protobufjs/protobuf.js/blob/69623a91c1e4a99d5210b5295a9e5b39d9517554/cli/util.js#L129 https://github.com/protobufjs/protobuf.js/blob/69623a91c1e4a99d5210b5295a9e5b39d9517554/package.json
other dependencies here should have the same major version as in protobufjs package.json
alexeagle
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Node version bump to current LTS.
Does this PR introduce a breaking change?
Builds not compatible with Node 12 could fail.
Builds relying on native dependencies in case if binaries for NODE_MODULE_VERSION=72 are not yet published for such dependency, will definitely fail (
bcrypt, etc.).Solution for such builds is quite straightforward though: use specific Node version in
node_repositoriesdefinition inWORKSPACEfile: