core: Map values are always treated as strings (Elem is ignored) #8104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
pushed a commit
that referenced
this pull request
Aug 11, 2016
* provider/aws: Re-implement api gateway parameter handling this PR cleans up some left overs from PR #4295, namely the parameter handling. now that GH-2143 is finally closed this PR does away with the ugly `request_parameters_in_json` and `response_parameters_in_json` hack. * Add deprecation message and conflictsWith settings following @radeksimko s advice, keeping the old code around with a deprecation warning. this should be cleaned up in a few releases * provider/aws: fix missing append operation * provider/aws: mark old parameters clearly as deprecated * provider/aws work around #8104 following @radeksimko s lead * provider/aws fix cnp error
jbardin
added a commit
that referenced
this pull request
Nov 21, 2016
Allow primitive types in schema maps
|
This was already implemented in #10203 and relevant validation was added in #12638 and #12722 respectively. We still do not have any clear way to specify mixed maps (values that aren't of the same type) and there may be some decision & thought process needed to get that done - but that's for a separate issue/PR. Maps with primitive values can now be specified like this: "mapInt": &Schema{
Type: TypeMap,
Elem: TypeInt,
}, |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attached is a failing test to demonstrate the issue.
I'm not sure if non-string maps were ever supposed to be supported, if not I think that we should be checking if
Elemis specified forTypeMapand if it is, we should be just returning error early.Related PRs/issues: