schema: Enable map value validation

[radeksimko]

I noticed we expect the Elem for maps to be ValueType directly per #10203 which probably makes sense for primitive types, because wrapping the type in Schema{} doesn't provide much benefits as most schema attributes don't make any sense in this context, e.g. Optional/Required/Computed - you cannot have value computed or not present as you'd have to know the key which means the whole pair has to be defined beforehand anyway and HCL has AFAIK no notion of a map with optional/no value.

That said we do have some Type: TypeMap, Elem: &Schema{Type: ValueType} in the codebase, specifically:

• data source aws_kms_secret: context
• data source consul_agent_self: advertise_addrs
• data source consul_catalog_nodes: tagged_addresses
• data source consul_catalog_service: tagged_addresses
• data source consul_catalog_services: services
• data source external: query
• data source external: result
• resource aws_ssm_document: permissions
• resource chef_environment: cookbook_constraints
• resource circonus_check: check_by_collector
• resource consul_key_prefix: subkeys
• resource datadog_monitor: thresholds
• resource ns1_user: notify
• resource test_resource: map_that_look_like_set

So all of these are well handled in this new validation, but we don't actually cast to right type at this point, so even if the type is right (passed validation), you'll get string values there anyway.

I'm happy to send a separate PR to tighten the internal validation too and modify the schema of the mentioned data sources and resources ^, but it will be obviously BC for any external/pluggable providers, so I'd like to hear some thoughts or at least 👍 / 👎 on this idea.

[jbardin]

yes, I like the added validation here. I think we can wait on the BC issues for when we decide how to properly handle nested data structures in general.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.