Fix hardware version bug

[appilon]

Description

vSphere refers to hardware_version in a vmx-xx format. The attribute is converted directly into an integer within provider schema I assume because it made version comparison more intuitive. HOWEVER because vSphere does in fact leftpad the integer with a leading 0 if the value is < 10, we could have left the attribute as is when initially designed and relied on lexicographical comparisons.

A recent change #1995 fixed an issue of setting the incorrect hardware version when using a template which has revealed this bug, that we naively did not leftpad the integer with a 0 when < 10. This change fixes this.

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
no regressions on VM resource
...

Release Note

Release note for CHANGELOG:

* `r/virtual_machine`: Fix hardware version conversion ([#2011](https://github.com/hashicorp/terraform-provider-vsphere/pull/2011))

References

Closes #2005

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.