Issue 1939 #1995
Merged
Issue 1939 #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code now correctly reads hardware version from the template and the terraform spec and passes along the higher of the two values to the environment browser. This allows configuration of vm deployments from templates with OSes newer than what the default hardware compatibility version of the ESXi server allows.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
appilon
approved these changes
Aug 17, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix for [issue 1939] (#1939)
Cloning and configuring VMs with newer guest operating systems (Windows 2022 in this case) was failing in some cases due to the backend using the ESXi default hardware version instead of the template or VM hardware version being cloned from or configured. This was causing the guest OS to not be recognised as supported.
Changed the backend pass the hardware version when retrieving the OS family.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Closes #1939